Fallback to Symbol.for("Symbol.metadata")

babel · Jan 16, 2022 · 0876e7a · 0876e7a
1 parent 2fc8ad9
commit 0876e7a
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 16 deletions.
diff --git a/packages/babel-helpers/src/helpers-generated.ts b/packages/babel-helpers/src/helpers-generated.ts
diff --git a/packages/babel-helpers/src/helpers/applyDecs.js b/packages/babel-helpers/src/helpers/applyDecs.js
@@ -76,7 +76,7 @@ function createMetadataMethodsForProperty(metadataMap, kind, property) {
 }
 
 function convertMetadataMapToFinal(obj, metadataMap) {
-  var parentMetadataMap = obj[Symbol.metadata];
+  var parentMetadataMap = obj[Symbol.metadata || Symbol.for("Symbol.metadata")];
   var metadataKeys = Object.getOwnPropertySymbols(metadataMap);
 
   if (metadataKeys.length === 0) return;
@@ -115,7 +115,7 @@ function convertMetadataMapToFinal(obj, metadataMap) {
     Object.setPrototypeOf(metadataMap, parentMetadataMap);
   }
 
-  obj[Symbol.metadata] = metadataMap;
+  obj[Symbol.metadata || Symbol.for("Symbol.metadata")] = metadataMap;
 }
 
 function createAddInitializerMethod(initializers) {

diff --git a/.../babel-plugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/class/exec.js b/.../babel-plugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/class/exec.js
@@ -7,4 +7,4 @@ function dec(_, { setMetadata }) {
 @dec
 class Foo {}
 
-expect(Foo[Symbol.metadata][key].constructor).toBe(123);
+expect(Foo[Symbol.for("Symbol.metadata")][key].constructor).toBe(123);
diff --git a/...orators/test/fixtures/2021-12-metadata--to-es2015/getting-previously-set-metadata/exec.js b/...orators/test/fixtures/2021-12-metadata--to-es2015/getting-previously-set-metadata/exec.js
@@ -26,5 +26,5 @@ class Bar extends Foo {
   @dec3 a;
 }
 
-expect(Foo.prototype[Symbol.metadata][key].public.a).toBe(456);
-expect(Bar.prototype[Symbol.metadata][key].public.a).toBe(789);
+expect(Foo.prototype[Symbol.for("Symbol.metadata")][key].public.a).toBe(456);
+expect(Bar.prototype[Symbol.for("Symbol.metadata")][key].public.a).toBe(789);
diff --git a/...proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/inheritance-private/exec.js b/...proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/inheritance-private/exec.js
@@ -12,5 +12,5 @@ class Bar extends Foo {
   @dec #b;
 }
 
-expect(Foo.prototype[Symbol.metadata][key].private).toEqual([123]);
-expect(Bar.prototype[Symbol.metadata][key].private).toEqual([123, 123]);
+expect(Foo.prototype[Symbol.for("Symbol.metadata")][key].private).toEqual([123]);
+expect(Bar.prototype[Symbol.for("Symbol.metadata")][key].private).toEqual([123, 123]);
diff --git a/...-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/inheritance-public/exec.js b/...-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/inheritance-public/exec.js
@@ -12,7 +12,7 @@ class Bar extends Foo {
   @dec b;
 }
 
-expect(Foo.prototype[Symbol.metadata][key].public.a).toEqual(123);
-expect(Foo.prototype[Symbol.metadata][key].public.b).toEqual(undefined);
-expect(Bar.prototype[Symbol.metadata][key].public.a).toEqual(123);
-expect(Bar.prototype[Symbol.metadata][key].public.b).toEqual(123);
+expect(Foo.prototype[Symbol.for("Symbol.metadata")][key].public.a).toEqual(123);
+expect(Foo.prototype[Symbol.for("Symbol.metadata")][key].public.b).toEqual(undefined);
+expect(Bar.prototype[Symbol.for("Symbol.metadata")][key].public.a).toEqual(123);
+expect(Bar.prototype[Symbol.for("Symbol.metadata")][key].public.b).toEqual(123);
diff --git a/...lugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/proto-private/exec.js b/...lugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/proto-private/exec.js
@@ -8,4 +8,4 @@ class Foo {
   @dec #a;
 }
 
-expect(Foo.prototype[Symbol.metadata][key].private[0]).toBe(123);
+expect(Foo.prototype[Symbol.for("Symbol.metadata")][key].private[0]).toBe(123);
diff --git a/...plugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/proto-public/exec.js b/...plugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/proto-public/exec.js
@@ -8,4 +8,4 @@ class Foo {
   @dec a;
 }
 
-expect(Foo.prototype[Symbol.metadata][key].public.a).toBe(123);
+expect(Foo.prototype[Symbol.for("Symbol.metadata")][key].public.a).toBe(123);
diff --git a/...ugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/static-private/exec.js b/...ugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/static-private/exec.js
@@ -8,4 +8,4 @@ class Foo {
   @dec static #a;
 }
 
-expect(Foo[Symbol.metadata][key].private[0]).toBe(123);
+expect(Foo[Symbol.for("Symbol.metadata")][key].private[0]).toBe(123);
diff --git a/...lugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/static-public/exec.js b/...lugin-proposal-decorators/test/fixtures/2021-12-metadata--to-es2015/static-public/exec.js
@@ -8,4 +8,4 @@ class Foo {
   @dec static a;
 }
 
-expect(Foo[Symbol.metadata][key].public.a).toBe(123);
+expect(Foo[Symbol.for("Symbol.metadata")][key].public.a).toBe(123);