Skip to content

Commit

Permalink
Convert @babel/eslint-plugin-development to CJS
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolo-ribaudo committed Jan 17, 2022
1 parent b423cb9 commit 0a446af
Show file tree
Hide file tree
Showing 13 changed files with 39 additions and 40 deletions.
14 changes: 14 additions & 0 deletions eslint/babel-eslint-plugin-development/src/index.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
const noDeprecatedClone = require("./rules/no-deprecated-clone.cjs");
const noUndefinedIdentifier = require("./rules/no-undefined-identifier.cjs");
const pluginName = require("./rules/plugin-name.cjs");

const rules = {
"no-deprecated-clone": noDeprecatedClone,
"no-undefined-identifier": noUndefinedIdentifier,
"plugin-name": pluginName,
};

exports.rules = rules;
if (!process.env.BABEL_8_BREAKING) {
exports.default = { rules };
}
11 changes: 0 additions & 11 deletions eslint/babel-eslint-plugin-development/src/index.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import getReferenceOrigin from "../utils/get-reference-origin";
import isFromBabelTypes from "../utils/is-from-babel-types";
const getReferenceOrigin = require("../utils/get-reference-origin.cjs");
const isFromBabelTypes = require("../utils/is-from-babel-types.cjs");

export default {
module.exports = {
meta: {
schema: [],
fixable: "code",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import getReferenceOrigin from "../utils/get-reference-origin";
import isFromBabelTypes from "../utils/is-from-babel-types";
const getReferenceOrigin = require("../utils/get-reference-origin.cjs");
const isFromBabelTypes = require("../utils/is-from-babel-types.cjs");

function firstArgumentIsUndefinedString(argumentsArray) {
return (
Expand All @@ -9,7 +9,7 @@ function firstArgumentIsUndefinedString(argumentsArray) {
);
}

export default {
module.exports = {
meta: {
schema: [],
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isBabelPluginFactory from "../utils/is-babel-plugin-factory";
const isBabelPluginFactory = require("../utils/is-babel-plugin-factory.cjs");

function getReturnValue(node) {
const { body } = node;
Expand All @@ -12,7 +12,7 @@ function getReturnValue(node) {
return body;
}

export default {
module.exports = {
meta: {
schema: [],
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function getExportName(node) {
module.exports = function getExportName(node) {
const { parent } = node;

if (parent.type === "ExportDefaultDeclaration") {
Expand All @@ -19,4 +19,4 @@ export default function getExportName(node) {
) {
return "module.exports";
}
}
};
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type ReferenceOrigin =
// from.
// It resolves imports, parameters of exported functions and property accesses.
// See the ReferenceOrigin type for more information.
export default function getReferenceOrigin(
module.exports = function getReferenceOrigin(
node,
scope,
) /*: ?ReferenceOrigin */ {
Expand Down Expand Up @@ -69,7 +69,7 @@ export default function getReferenceOrigin(
}

return null;
}
};

function getVariableDefinition(name, scope) {
let currentScope = scope;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import getReferenceOrigin from "./get-reference-origin";
import getExportName from "./get-export-name";
const getReferenceOrigin = require("./get-reference-origin.cjs");
const getExportName = require("./get-export-name.cjs");

export default function isBabelPluginFactory(node, scope) {
module.exports = function isBabelPluginFactory(node, scope) {
const { parent } = node;

if (parent.type === "CallExpression") {
Expand All @@ -21,4 +21,4 @@ export default function isBabelPluginFactory(node, scope) {
// export default function ({ types: t }) {}
// module.exports = function ({ types: t }) {}
return exportName === "default" || exportName === "module.exports";
}
};
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import isBabelPluginFactory from "./is-babel-plugin-factory";
const isBabelPluginFactory = require("./is-babel-plugin-factory.cjs");

// Check if a ReferenceOrigin (returned by ./get-reference-origin.js)
// is a reference to a @babel/types export.
export default function isFromBabelTypes(
module.exports = function isFromBabelTypes(
origin /*: ReferenceOrigin */,
scope /*: Scope */,
) {
Expand Down Expand Up @@ -30,4 +30,4 @@ export default function isFromBabelTypes(
}

return false;
}
};
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import rule from "../../lib/rules/no-deprecated-clone.js";
import rule from "../../lib/rules/no-deprecated-clone.cjs";
import RuleTester from "../../../babel-eslint-shared-fixtures/utils/RuleTester.js";

const cloneError = "t.clone() is deprecated. Use t.cloneNode() instead.";
Expand All @@ -9,7 +9,7 @@ const ruleTester = new RuleTester({
parserOptions: { sourceType: "module" },
});

ruleTester.run("no-deprecated-clone", rule.default, {
ruleTester.run("no-deprecated-clone", rule, {
valid: [
`_.clone(obj)`,
`_.cloneDeep(obj)`,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import rule from "../../lib/rules/no-undefined-identifier.js";
import rule from "../../lib/rules/no-undefined-identifier.cjs";
import RuleTester from "../../../babel-eslint-shared-fixtures/utils/RuleTester.js";

const error =
Expand All @@ -8,7 +8,7 @@ const ruleTester = new RuleTester({
parserOptions: { sourceType: "module" },
});

ruleTester.run("no-undefined-identifier", rule.default, {
ruleTester.run("no-undefined-identifier", rule, {
valid: [
`_.identifier("undefined")`,
`_.Identifier("undefined")`,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import rule from "../../lib/rules/plugin-name.js";
import rule from "../../lib/rules/plugin-name.cjs";
import RuleTester from "../../../babel-eslint-shared-fixtures/utils/RuleTester.js";

const missingPluginError = "This file does not export a Babel plugin.";
const missingNameError = "This Babel plugin doesn't have a 'name' property.";

const ruleTester = new RuleTester();

ruleTester.run("plugin-name", rule.default, {
ruleTester.run("plugin-name", rule, {
valid: [
`export default function () { return { name: "test-plugin" } }`,
`import { declare } from "@babel/helper-plugin-utils"; declare(() => { return { name: "test-plugin" } })`,
Expand Down
4 changes: 0 additions & 4 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@
"./packages/babel-template/src/**/*.ts",
"./packages/babel-traverse/src/**/*.ts",
"./packages/babel-types/src/**/*.ts",
"./eslint/babel-eslint-plugin-development/src/**/*.ts",
"./eslint/babel-eslint-plugin-development-internal/src/**/*.ts",
"./codemods/babel-plugin-codemod-object-assign-to-object-spread/src/**/*.ts",
"./codemods/babel-plugin-codemod-optional-catch-binding/src/**/*.ts"
Expand Down Expand Up @@ -561,9 +560,6 @@
"@babel/types": [
"./packages/babel-types/src"
],
"@babel/eslint-plugin-development": [
"./eslint/babel-eslint-plugin-development/src"
],
"@babel/eslint-plugin-development-internal": [
"./eslint/babel-eslint-plugin-development-internal/src"
],
Expand Down

0 comments on commit 0a446af

Please sign in to comment.