Address review comments

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
babel · Oct 12, 2020 · 0b4dc58 · 0b4dc58
1 parent 04fa4bf
commit 0b4dc58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/babel-parser/src/parser/error-message.js b/packages/babel-parser/src/parser/error-message.js
@@ -44,7 +44,7 @@ export const ErrorMessages = Object.freeze({
   ElementAfterRest: "Rest element must be last element",
   EscapedCharNotAnIdentifier: "Invalid Unicode escape",
   ExportBindingIsString:
-    "Can not use string literal as exported binding without `from`.\n- Did you mean `export { %0 as '%1' } from 'some-module'`",
+    "Can not use string literal as exported binding without `from`.\n- Did you mean `export { %0 as '%1' } from 'some-module'`?",
   ExportDefaultFromAsIdentifier:
     "'from' is not allowed as an identifier after 'export default'",
   ForInOfLoopInitializer:

diff --git a/...ixtures/experimental/module-string-names/string-exported-binding-without-from/output.json b/...ixtures/experimental/module-string-names/string-exported-binding-without-from/output.json
@@ -2,8 +2,8 @@
   "type": "File",
   "start":0,"end":45,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":45}},
   "errors": [
-    "SyntaxError: Can not use string literal as exported binding without `from`.\n- Did you mean `export { \"學而時習之，不亦說乎？\" as '學而時習之，不亦說乎？' } from 'some-module'` (1:9)",
-    "SyntaxError: Can not use string literal as exported binding without `from`.\n- Did you mean `export { \"吾道一以貫之。\" as '忠恕。' } from 'some-module'` (1:24)"
+    "SyntaxError: Can not use string literal as exported binding without `from`.\n- Did you mean `export { \"學而時習之，不亦說乎？\" as '學而時習之，不亦說乎？' } from 'some-module'`? (1:9)",
+    "SyntaxError: Can not use string literal as exported binding without `from`.\n- Did you mean `export { \"吾道一以貫之。\" as '忠恕。' } from 'some-module'`? (1:24)"
   ],
   "program": {
     "type": "Program",