Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add support for logical assignments with private properties
Patches the logic for handling assignment operators and adds support for handling the logical assignment operators appropriately. Fixes: #11646
- Loading branch information
Showing
4 changed files
with
69 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
.../babel-plugin-proposal-class-properties/test/fixtures/private/logical-assignment/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
class Foo { | ||
#nullish = 0; | ||
#and = 0; | ||
#or = 0; | ||
|
||
test() { | ||
this.#nullish ??= 42; | ||
this.#and &&= 0; | ||
this.#or ||= 0; | ||
} | ||
} |
6 changes: 6 additions & 0 deletions
6
...el-plugin-proposal-class-properties/test/fixtures/private/logical-assignment/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"plugins": [ | ||
"proposal-logical-assignment-operators", | ||
"proposal-class-properties" | ||
] | ||
} |
37 changes: 37 additions & 0 deletions
37
...babel-plugin-proposal-class-properties/test/fixtures/private/logical-assignment/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
function _classPrivateFieldSet(receiver, privateMap, value) { var descriptor = privateMap.get(receiver); if (!descriptor) { throw new TypeError("attempted to set private field on non-instance"); } if (descriptor.set) { descriptor.set.call(receiver, value); } else { if (!descriptor.writable) { throw new TypeError("attempted to set read only private field"); } descriptor.value = value; } return value; } | ||
|
||
function _classPrivateFieldGet(receiver, privateMap) { var descriptor = privateMap.get(receiver); if (!descriptor) { throw new TypeError("attempted to get private field on non-instance"); } if (descriptor.get) { return descriptor.get.call(receiver); } return descriptor.value; } | ||
|
||
var _nullish = new WeakMap(); | ||
|
||
var _and = new WeakMap(); | ||
|
||
var _or = new WeakMap(); | ||
|
||
class Foo { | ||
constructor() { | ||
_nullish.set(this, { | ||
writable: true, | ||
value: 0 | ||
}); | ||
|
||
_and.set(this, { | ||
writable: true, | ||
value: 0 | ||
}); | ||
|
||
_or.set(this, { | ||
writable: true, | ||
value: 0 | ||
}); | ||
} | ||
|
||
test() { | ||
_classPrivateFieldSet(this, _nullish, _classPrivateFieldGet(this, _nullish) ?? 42); | ||
|
||
_classPrivateFieldSet(this, _and, _classPrivateFieldGet(this, _and) && 0); | ||
|
||
_classPrivateFieldSet(this, _or, _classPrivateFieldGet(this, _or) || 0); | ||
} | ||
|
||
} |