Don't allow JSXNamespacedName to chain (#10366)

Eg, `namespace:foo.bar` used to parse but is invalid in the [spec](https://facebook.github.io/jsx/). Also, allow `JSXNamespacedName` in the `JSXOpeningElement`/`JSXClosingElement` builders.
babel · Aug 26, 2019 · 1664cce · 1664cce
1 parent a2bf689
commit 1664cce
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 3 deletions.
diff --git a/packages/babel-parser/src/plugins/jsx/index.js b/packages/babel-parser/src/plugins/jsx/index.js
@@ -250,10 +250,16 @@ export default (superClass: Class<Parser>): Class<Parser> =>
     // Parses element name in any form - namespaced, member
     // or single identifier.
 
-    jsxParseElementName(): N.JSXNamespacedName | N.JSXMemberExpression {
+    jsxParseElementName():
+      | N.JSXIdentifier
+      | N.JSXNamespacedName
+      | N.JSXMemberExpression {
       const startPos = this.state.start;
       const startLoc = this.state.startLoc;
       let node = this.jsxParseNamespacedName();
+      if (node.type === "JSXNamespacedName") {
+        return node;
+      }
       while (this.eat(tt.dot)) {
         const newNode = this.startNodeAt(startPos, startLoc);
         newNode.object = node;

diff --git a/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-1/input.js b/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-1/input.js
@@ -0,0 +1 @@
+<a.b:c />
diff --git a/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-1/options.json b/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-1/options.json
@@ -0,0 +1,3 @@
+{
+  "throws": "Unexpected token (1:4)"
+}
diff --git a/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-2/input.js b/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-2/input.js
@@ -0,0 +1 @@
+<a:b.c />
diff --git a/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-2/options.json b/packages/babel-parser/test/fixtures/jsx/errors/member-in-namespace-2/options.json
@@ -0,0 +1,3 @@
+{
+  "throws": "Unexpected token (1:4)"
+}
diff --git a/packages/babel-types/src/definitions/jsx.js b/packages/babel-types/src/definitions/jsx.js
@@ -30,7 +30,11 @@ defineType("JSXClosingElement", {
   aliases: ["JSX", "Immutable"],
   fields: {
     name: {
-      validate: assertNodeType("JSXIdentifier", "JSXMemberExpression"),
+      validate: assertNodeType(
+        "JSXIdentifier",
+        "JSXMemberExpression",
+        "JSXNamespacedName",
+      ),
     },
   },
 });
@@ -130,7 +134,11 @@ defineType("JSXOpeningElement", {
   aliases: ["JSX", "Immutable"],
   fields: {
     name: {
-      validate: assertNodeType("JSXIdentifier", "JSXMemberExpression"),
+      validate: assertNodeType(
+        "JSXIdentifier",
+        "JSXMemberExpression",
+        "JSXNamespacedName",
+      ),
     },
     selfClosing: {
       default: false,