Skip warning check that fails release tests (#15657)

babel · May 26, 2023 · 19e89e7 · 19e89e7
1 parent 92e31fc
commit 19e89e7
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/...generator/test/fixtures/importAttributesKeyword/attributes-assert-to-default/options.json b/...generator/test/fixtures/importAttributesKeyword/attributes-assert-to-default/options.json
@@ -1,4 +1,6 @@
 {
+  "_": "The warning is only shown once in the release build, tested by the assertions-with-to-default fixture",
+  "noWarnInPublishBuild": true,
   "plugins": [["importAttributes", { "deprecatedAssertSyntax": true }]],
   "warns": "You are using import attributes, without specifying the desired output syntax.",
   "expectedReParseError": true

diff --git a/...l-generator/test/fixtures/importAttributesKeyword/attributes-with-to-default/options.json b/...l-generator/test/fixtures/importAttributesKeyword/attributes-with-to-default/options.json
@@ -1,4 +1,6 @@
 {
+  "_": "The warning is only shown once in the release build, tested by the assertions-with-to-default fixture",
+  "noWarnInPublishBuild": true,
   "plugins": ["importAttributes"],
   "warns": "You are using import attributes, without specifying the desired output syntax.",
   "expectedReParseError": true

diff --git a/...or/test/fixtures/importAttributesKeyword/legacy-module-attributes-to-default/options.json b/...or/test/fixtures/importAttributesKeyword/legacy-module-attributes-to-default/options.json
@@ -1,4 +1,6 @@
 {
+  "_": "The warning is only shown once in the release build, tested by the assertions-with-to-default fixture",
+  "noWarnInPublishBuild": true,
   "plugins": [["moduleAttributes", { "version": "may-2020" }]],
   "warns": "You are using import attributes, without specifying the desired output syntax.",
   "BABEL_8_BREAKING": false

diff --git a/packages/babel-generator/test/fixtures/types/ModuleAttributes/options.json b/packages/babel-generator/test/fixtures/types/ModuleAttributes/options.json
@@ -1,7 +1,7 @@
 {
-  "plugins": [
-    ["moduleAttributes", { "version": "may-2020" }]
-  ],
+  "_": "The warning is only shown once in the release build, tested by the assertions-with-to-default fixture",
+  "noWarnInPublishBuild": true,
+  "plugins": [["moduleAttributes", { "version": "may-2020" }]],
   "sourceType": "module",
   "warns": "You are using import attributes, without specifying the desired output syntax.",
   "BABEL_8_BREAKING": false

diff --git a/packages/babel-generator/test/index.js b/packages/babel-generator/test/index.js
@@ -1489,7 +1489,10 @@ suites.forEach(function (testSuite) {
 
               const result = run();
 
-              if (options.warns) {
+              if (
+                options.warns &&
+                (!process.env.IS_PUBLISH || !options.noWarnInPublishBuild)
+              ) {
                 expect(console.warn).toHaveBeenCalledWith(
                   expect.stringContaining(options.warns),
                 );