fix(referencesImport): do not be fooled by import name "*"

at least when detecting accessing a named import via a '*' import
babel · Jan 16, 2021 · 1b232a5 · 1b232a5
1 parent ad2e2d1
commit 1b232a5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/babel-traverse/src/path/introspection.js b/packages/babel-traverse/src/path/introspection.js
@@ -164,7 +164,11 @@ export function referencesImport(moduleSource, importName) {
         ? t.isStringLiteral(this.node.property, { value: importName })
         : this.node.property.name === importName)
     ) {
-      return this.get("object").referencesImport(moduleSource, "*");
+      const object = this.get("object");
+      return (
+        object.isReferencedIdentifier() &&
+        object.referencesImport(moduleSource, "*")
+      );
     }
 
     return false;

diff --git a/packages/babel-traverse/test/introspection.js b/packages/babel-traverse/test/introspection.js
@@ -173,6 +173,14 @@ describe("path/introspection", function () {
       const reference = program.get("body.1.expression");
       expect(reference.referencesImport("source", "dep")).toBe(false);
     });
+    it('rejects the "export called *" trick', function () {
+      const program = getPath(`import * as ns from "source"; ns["*"].nested;`, {
+        sourceType: "module",
+        plugins: ["moduleStringNames"],
+      });
+      const reference = program.get("body.1.expression");
+      expect(reference.referencesImport("source", "nested")).toBe(false);
+    });
 
     it("accepts a namespace import", function () {
       const program = getPath(`import * as dep from "source"; dep;`, {