address review comments

babel · Jul 11, 2020 · 1e796b3 · 1e796b3
1 parent b7f9cf5
commit 1e796b3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/packages/babel-plugin-transform-parameters/src/params.js b/packages/babel-plugin-transform-parameters/src/params.js
@@ -229,6 +229,6 @@ function buildScopeIIFE(shadowedParams, body) {
   }
 
   return t.returnStatement(
-    t.callExpression(t.arrowFunctionExpression(args, body), params),
+    t.callExpression(t.arrowFunctionExpression(params, body), args),
   );
 }
diff --git a/packages/babel-plugin-transform-typescript/src/index.js b/packages/babel-plugin-transform-typescript/src/index.js
@@ -134,9 +134,8 @@ export default declare(
               );
             }
 
-            return template.statement.ast`this.${t.cloneNode(
-              id,
-            )} = ${t.cloneNode(id)}`;
+            return template.statement.ast`
+              this.${t.cloneNode(id)} = ${t.cloneNode(id)}`;
           });
 
           injectInitialization(classPath, path, assigns);

diff --git a/packages/babel-plugin-transform-typescript/src/namespace.js b/packages/babel-plugin-transform-typescript/src/namespace.js
@@ -156,12 +156,10 @@ function handleNested(path, t, node, parentExport) {
   let fallthroughValue = t.objectExpression([]);
 
   if (parentExport) {
+    const memberExpr = t.memberExpression(parentExport, realName);
     fallthroughValue = template.expression.ast`
-      ${parentExport}.${t.cloneNode(realName)} || (
-        ${t.cloneNode(parentExport)}.${t.cloneNode(
-      realName,
-    )} = ${fallthroughValue}
-      )
+      ${t.cloneNode(memberExpr)} ||
+        (${t.cloneNode(memberExpr)} = ${fallthroughValue})
     `;
   }