Support in @babel/types

babel · Apr 29, 2022 · 24d147b · 24d147b
1 parent c341cda
commit 24d147b
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 3 deletions.
diff --git a/packages/babel-types/src/definitions/core.ts b/packages/babel-types/src/definitions/core.ts
@@ -66,6 +66,9 @@ defineType("AssignmentExpression", {
             "MemberExpression",
             "ArrayPattern",
             "ObjectPattern",
+            "TSAsExpresion",
+            "TSTypeAssertion",
+            "TSNonNullExpression",
           ),
     },
     right: {
@@ -319,6 +322,9 @@ defineType("ForInStatement", {
             "MemberExpression",
             "ArrayPattern",
             "ObjectPattern",
+            "TSAsExpresion",
+            "TSTypeAssertion",
+            "TSNonNullExpression",
           ),
     },
     right: {
@@ -906,6 +912,9 @@ defineType("RestElement", {
             "ArrayPattern",
             "ObjectPattern",
             "MemberExpression",
+            "TSAsExpresion",
+            "TSTypeAssertion",
+            "TSNonNullExpression",
           ),
     },
     // For Flow
@@ -1183,6 +1192,9 @@ defineType("AssignmentPattern", {
         "ObjectPattern",
         "ArrayPattern",
         "MemberExpression",
+        "TSAsExpression",
+        "TSTypeAssertion",
+        "TSNonNullExpression",
       ),
     },
     right: {
@@ -1583,6 +1595,9 @@ defineType("ForOfStatement", {
           "MemberExpression",
           "ArrayPattern",
           "ObjectPattern",
+          "TSAsExpresion",
+          "TSTypeAssertion",
+          "TSNonNullExpression",
         );
 
         return function (node, key, val) {

diff --git a/packages/babel-types/src/definitions/typescript.ts b/packages/babel-types/src/definitions/typescript.ts
@@ -450,7 +450,7 @@ defineType("TSTypeAliasDeclaration", {
 });
 
 defineType("TSAsExpression", {
-  aliases: ["Expression"],
+  aliases: ["Expression", "LVal", "PatternLike"],
   visitor: ["expression", "typeAnnotation"],
   fields: {
     expression: validateType("Expression"),
@@ -459,7 +459,7 @@ defineType("TSAsExpression", {
 });
 
 defineType("TSTypeAssertion", {
-  aliases: ["Expression"],
+  aliases: ["Expression", "LVal", "PatternLike"],
   visitor: ["typeAnnotation", "expression"],
   fields: {
     typeAnnotation: validateType("TSType"),
@@ -542,7 +542,7 @@ defineType("TSExternalModuleReference", {
 });
 
 defineType("TSNonNullExpression", {
-  aliases: ["Expression"],
+  aliases: ["Expression", "LVal", "PatternLike"],
   visitor: ["expression"],
   fields: {
     expression: validateType("Expression"),

diff --git a/packages/babel-types/test/validate.js b/packages/babel-types/test/validate.js
@@ -0,0 +1,30 @@
+import * as t from "../lib/index.js";
+
+describe("validate", () => {
+  describe("TS", () => {
+    const id1 = t.identifier("foo");
+    const id2 = t.identifier("bar");
+    const lhs = [
+      t.tsAsExpression(id1, t.tsAnyKeyword()),
+      t.tsTypeAssertion(t.tsAnyKeyword(), id1),
+      t.tsNonNullExpression(id1),
+    ];
+    const validNodes = {
+      "AssignmentExpression(=)": lhs => t.assignmentExpression("=", lhs, id2),
+      "AssignmentExpression(+=)": lhs => t.assignmentExpression("+=", lhs, id2),
+      ForOfStatement: lhs => t.forOfStatement(lhs, id2, t.emptyStatement()),
+      ForInStatement: lhs => t.forInStatement(lhs, id2, t.emptyStatement()),
+      "ObjectPattern > ObjectProperty": lhs =>
+        t.objectPattern([t.objectProperty(t.stringLiteral("x"), lhs)]),
+      ArrayPattern: lhs => t.arrayPattern([lhs]),
+      AssignmentPattern: lhs => t.assignmentPattern(lhs, id2),
+    };
+    Object.keys(validNodes).forEach(name => {
+      lhs.forEach(lhs => {
+        it(`${lhs.type} is allowed in ${name}`, () => {
+          expect(() => t.validate(validNodes[name](lhs))).not.toThrow();
+        });
+      });
+    });
+  });
+});