Remove using await restriction in explicitResourceManagement (#15602)

babel · May 2, 2023 · 2942629 · 2942629
1 parent 213de75
commit 2942629
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 14 deletions.
diff --git a/packages/babel-parser/src/parse-error/standard-errors.ts b/packages/babel-parser/src/parse-error/standard-errors.ts
@@ -33,8 +33,6 @@ export default {
     "Can not use 'await' as identifier inside a static block.",
   AwaitExpressionFormalParameter:
     "'await' is not allowed in async function parameters.",
-  AwaitInUsingBinding:
-    "'await' is not allowed to be used as a name in 'using' declarations.",
   AwaitNotInAsyncContext:
     "'await' is only allowed within async functions and at the top levels of modules.",
   AwaitNotInAsyncFunction: "'await' is only allowed within async functions.",

diff --git a/packages/babel-parser/src/parser/statement.ts b/packages/babel-parser/src/parser/statement.ts
@@ -484,7 +484,7 @@ export default abstract class StatementParser extends ExpressionParser {
         return this.parseTryStatement(node as Undone<N.TryStatement>);
 
       case tt._using:
-        // using [no LineTerminator here][lookahead != `await`] BindingList[+Using]
+        // using [no LineTerminator here] BindingList[+Using]
         if (
           this.state.containsEsc ||
           !this.hasInLineFollowingBindingIdentifier()
@@ -1536,11 +1536,6 @@ export default abstract class StatementParser extends ExpressionParser {
     decl: Undone<N.VariableDeclarator>,
     kind: "var" | "let" | "const" | "using",
   ): void {
-    // Unlike "let" which must be handled in checkLVal, it suffices to check
-    // await here because `using` must not precede binding patterns.
-    if (kind === "using" && !this.inModule && this.match(tt._await)) {
-      this.raise(Errors.AwaitInUsingBinding, { at: this.state.startLoc });
-    }
     const id = this.parseBindingAtom();
     this.checkLVal(id, {
       in: { type: "VariableDeclarator" },

diff --git a/...valid-using-binding-await-script/input.js → ...valid-using-binding-await-script/input.js b/...valid-using-binding-await-script/input.js → ...valid-using-binding-await-script/input.js
diff --git a/...d-using-binding-await-script/options.json → ...d-using-binding-await-script/options.json b/...d-using-binding-await-script/options.json → ...d-using-binding-await-script/options.json
diff --git a/...id-using-binding-await-script/output.json → ...id-using-binding-await-script/output.json b/...id-using-binding-await-script/output.json → ...id-using-binding-await-script/output.json
@@ -1,12 +1,6 @@
 {
   "type": "File",
   "start":0,"end":113,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":12,"column":1,"index":113}},
-  "errors": [
-    "SyntaxError: 'await' is not allowed to be used as a name in 'using' declarations. (2:8)",
-    "SyntaxError: 'await' is not allowed to be used as a name in 'using' declarations. (5:8)",
-    "SyntaxError: 'await' is not allowed to be used as a name in 'using' declarations. (8:11)",
-    "SyntaxError: 'await' is not allowed to be used as a name in 'using' declarations. (11:13)"
-  ],
   "program": {
     "type": "Program",
     "start":0,"end":113,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":12,"column":1,"index":113}},