enable TS compiler option: strictBindCallApply (#14685)

babel · Jun 22, 2022 · 3636faa · 3636faa
1 parent b1e73d6
commit 3636faa
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/packages/babel-generator/src/generators/flow.ts b/packages/babel-generator/src/generators/flow.ts
@@ -156,13 +156,16 @@ export function DeclareExportDeclaration(
     this.space();
   }
 
-  FlowExportDeclaration.apply(this, arguments);
+  FlowExportDeclaration.call(this, node);
 }
 
-export function DeclareExportAllDeclaration(this: Printer) {
+export function DeclareExportAllDeclaration(
+  this: Printer,
+  node: t.DeclareExportAllDeclaration,
+) {
   this.word("declare");
   this.space();
-  ExportAllDeclaration.apply(this, arguments);
+  ExportAllDeclaration.call(this, node);
 }
 
 export function EnumDeclaration(this: Printer, node: t.EnumDeclaration) {

diff --git a/packages/babel-generator/src/generators/modules.ts b/packages/babel-generator/src/generators/modules.ts
@@ -68,7 +68,7 @@ export function ExportNamespaceSpecifier(
 
 export function ExportAllDeclaration(
   this: Printer,
-  node: t.ExportAllDeclaration,
+  node: t.ExportAllDeclaration | t.DeclareExportAllDeclaration,
 ) {
   this.word("export");
   this.space();
@@ -81,6 +81,7 @@ export function ExportAllDeclaration(
   this.word("from");
   this.space();
   this.print(node.source, node);
+  // @ts-expect-error Fixme: assertions is not defined in DeclareExportAllDeclaration
   this.printAssertions(node);
   this.semicolon();
 }

diff --git a/packages/babel-types/src/converters/valueToNode.ts b/packages/babel-types/src/converters/valueToNode.ts
@@ -31,6 +31,7 @@ export default valueToNode as {
   (value: unknown): t.Expression;
 };
 
+// @ts-expect-error: Object.prototype.toString must return a string
 const objectToString: (value: unknown) => string = Function.call.bind(
   Object.prototype.toString,
 );

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -13,6 +13,7 @@
     "skipLibCheck": true,
     "resolveJsonModule": true,
     "noImplicitThis": true,
-    "noImplicitAny": true
+    "noImplicitAny": true,
+    "strictBindCallApply": true
   }
 }