fix: Correctly prints { [key in Bar]? } (#16402)

fix
babel · Apr 2, 2024 · 38c14c3 · 38c14c3
1 parent dd699a8
commit 38c14c3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/packages/babel-generator/src/generators/typescript.ts b/packages/babel-generator/src/generators/typescript.ts
@@ -443,11 +443,12 @@ export function TSMappedType(this: Printer, node: t.TSMappedType) {
 
   this.token("]");
 
+  if (optional) {
+    tokenIfPlusMinus(this, optional);
+    this.token("?");
+  }
+
   if (typeAnnotation) {
-    if (optional) {
-      tokenIfPlusMinus(this, optional);
-      this.token("?");
-    }
     this.token(":");
     this.space();
     this.print(typeAnnotation, node);

diff --git a/packages/babel-generator/test/fixtures/typescript/mapped-type/input.ts b/packages/babel-generator/test/fixtures/typescript/mapped-type/input.ts
@@ -1 +1,4 @@
 type Bar = { [key in Foo] };
+type Foo2 = { [key in Bar]? };
+type Foo3 = { [key in keyof Bar]-? };
+type Foo4 = { [key in keyof Bar]+? };
diff --git a/packages/babel-generator/test/fixtures/typescript/mapped-type/output.js b/packages/babel-generator/test/fixtures/typescript/mapped-type/output.js
@@ -1 +1,4 @@
-type Bar = { [key in Foo] };
+type Bar = { [key in Foo] };
+type Foo2 = { [key in Bar]? };
+type Foo3 = { [key in keyof Bar]-? };
+type Foo4 = { [key in keyof Bar]+? };