maintain estree string literal shape when cloned (#14039)

babel · Dec 9, 2021 · 3908049 · 3908049
1 parent 94af0e5
commit 3908049
Show file tree

Hide file tree

Showing 5 changed files with 54 additions and 5 deletions.
diff --git a/packages/babel-parser/src/parser/node.js b/packages/babel-parser/src/parser/node.js
@@ -79,12 +79,17 @@ export function cloneStringLiteral(node: any): any {
     return clonePlaceholder(node);
   }
   const cloned = Object.create(NodePrototype);
-  cloned.type = "StringLiteral";
+  cloned.type = type;
   cloned.start = start;
   cloned.end = end;
   cloned.loc = loc;
   cloned.range = range;
-  cloned.extra = extra;
+  if (node.raw !== undefined) {
+    // estree set node.raw instead of node.extra
+    cloned.raw = node.raw;
+  } else {
+    cloned.extra = extra;
+  }
   cloned.value = node.value;
   return cloned;
 }

diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/mixed/options.json b/packages/babel-parser/test/fixtures/estree/module-string-names/mixed/options.json
diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/options.json b/packages/babel-parser/test/fixtures/estree/module-string-names/options.json
@@ -0,0 +1,4 @@
+{
+  "sourceType": "module",
+  "plugins": ["flow", "jsx", "estree"]
+}
diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/input.js b/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/input.js
@@ -0,0 +1 @@
+export { "foo" } from "module-a";
diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/output.json b/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/output.json
@@ -0,0 +1,42 @@
+{
+  "type": "File",
+  "start":0,"end":33,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":33}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":33,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":33}},
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExportNamedDeclaration",
+        "start":0,"end":33,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":33}},
+        "specifiers": [
+          {
+            "type": "ExportSpecifier",
+            "start":9,"end":14,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":14}},
+            "local": {
+              "type": "Literal",
+              "start":9,"end":14,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":14}},
+              "value": "foo",
+              "raw": "\"foo\""
+            },
+            "exported": {
+              "type": "Literal",
+              "start":9,"end":14,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":14}},
+              "raw": "\"foo\"",
+              "value": "foo"
+            }
+          }
+        ],
+        "source": {
+          "type": "Literal",
+          "start":22,"end":32,"loc":{"start":{"line":1,"column":22},"end":{"line":1,"column":32}},
+          "value": "module-a",
+          "raw": "\"module-a\""
+        },
+        "declaration": null,
+        "exportKind": "value"
+      }
+    ]
+  }
+}