Use buildUndefinedNode in accessor templates

babel · Aug 23, 2019 · 3e6c955 · 3e6c955
1 parent 3f8d021
commit 3e6c955
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 16 deletions.
diff --git a/packages/babel-helper-create-class-features-plugin/src/fields.js b/packages/babel-helper-create-class-features-plugin/src/fields.js
@@ -319,8 +319,8 @@ function buildPrivateStaticFieldInitSpec(prop, privateNamesMap) {
         // configurable is false by default
         // enumerable is false by default
         // writable is false by default
-        get: ${getId ? getId.name : "null"},
-        set: ${setId ? setId.name : "null"}
+        get: ${getId ? getId.name : prop.scope.buildUndefinedNode()},
+        set: ${setId ? setId.name : prop.scope.buildUndefinedNode()}
       }
     `;
   }
@@ -363,8 +363,8 @@ function buildPrivateMethodInitLoose(ref, prop, privateNamesMap) {
         // configurable is false by default
         // enumerable is false by default
         // writable is false by default
-        get: ${getId ? getId.name : "undefined"},
-        set: ${setId ? setId.name : "undefined"}
+        get: ${getId ? getId.name : prop.scope.buildUndefinedNode()},
+        set: ${setId ? setId.name : prop.scope.buildUndefinedNode()}
       });
     `;
   }
@@ -383,8 +383,8 @@ function buildPrivateInstanceMethodInitSpec(ref, prop, privateNamesMap) {
 
     return template.statement.ast`
       ${id}.set(${ref}, {
-        get: ${getId ? getId.name : "undefined"},
-        set: ${setId ? setId.name : "undefined"}
+        get: ${getId ? getId.name : prop.scope.buildUndefinedNode()},
+        set: ${setId ? setId.name : prop.scope.buildUndefinedNode()}
       });
     `;
   }
@@ -433,8 +433,8 @@ function buildPrivateStaticMethodInitLoose(ref, prop, state, privateNamesMap) {
         // configurable is false by default
         // enumerable is false by default
         // writable is false by default
-        get: ${getId ? getId.name : "undefined"},
-        set: ${setId ? setId.name : "undefined"}
+        get: ${getId ? getId.name : prop.scope.buildUndefinedNode()},
+        set: ${setId ? setId.name : prop.scope.buildUndefinedNode()}
       })
     `;
   }

diff --git a/...l-plugin-proposal-private-methods/test/fixtures/accessors-loose/get-only-setter/output.js b/...l-plugin-proposal-private-methods/test/fixtures/accessors-loose/get-only-setter/output.js
@@ -1,7 +1,7 @@
 class Cl {
   constructor() {
     Object.defineProperty(this, _privateFieldValue, {
-      get: undefined,
+      get: void 0,
       set: _set_privateFieldValue
     });
     Object.defineProperty(this, _privateField, {

diff --git a/...l-plugin-proposal-private-methods/test/fixtures/accessors-loose/set-only-getter/output.js b/...l-plugin-proposal-private-methods/test/fixtures/accessors-loose/set-only-getter/output.js
@@ -2,7 +2,7 @@ class Cl {
   constructor() {
     Object.defineProperty(this, _privateFieldValue, {
       get: _get_privateFieldValue,
-      set: undefined
+      set: void 0
     });
     Object.defineProperty(this, _privateField, {
       writable: true,

diff --git a/...s/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/output.js b/...s/babel-plugin-proposal-private-methods/test/fixtures/accessors/get-only-setter/output.js
@@ -1,7 +1,7 @@
 class Cl {
   constructor() {
     _privateFieldValue.set(this, {
-      get: undefined,
+      get: void 0,
       set: _set_privateFieldValue
     });
 

diff --git a/...s/babel-plugin-proposal-private-methods/test/fixtures/accessors/set-only-getter/output.js b/...s/babel-plugin-proposal-private-methods/test/fixtures/accessors/set-only-getter/output.js
@@ -2,7 +2,7 @@ class Cl {
   constructor() {
     _privateFieldValue.set(this, {
       get: _get_privateFieldValue,
-      set: undefined
+      set: void 0
     });
 
     _privateField.set(this, {

diff --git a/...n-proposal-private-methods/test/fixtures/static-accessors-loose/get-only-setter/output.js b/...n-proposal-private-methods/test/fixtures/static-accessors-loose/get-only-setter/output.js
@@ -18,6 +18,6 @@ Object.defineProperty(Cl, _PRIVATE_STATIC_FIELD, {
   value: 0
 });
 Object.defineProperty(Cl, _privateStaticFieldValue, {
-  get: undefined,
+  get: void 0,
   set: _set_privateStaticFieldValue
 });
diff --git a/...n-proposal-private-methods/test/fixtures/static-accessors-loose/set-only-getter/output.js b/...n-proposal-private-methods/test/fixtures/static-accessors-loose/set-only-getter/output.js
@@ -19,5 +19,5 @@ Object.defineProperty(Cl, _PRIVATE_STATIC_FIELD, {
 });
 Object.defineProperty(Cl, _privateStaticFieldValue, {
   get: _get_privateStaticFieldValue,
-  set: undefined
+  set: void 0
 });
diff --git a/...-plugin-proposal-private-methods/test/fixtures/static-accessors/get-only-setter/output.js b/...-plugin-proposal-private-methods/test/fixtures/static-accessors/get-only-setter/output.js
@@ -14,6 +14,6 @@ var _PRIVATE_STATIC_FIELD = {
   value: 0
 };
 var _privateStaticFieldValue = {
-  get: null,
+  get: void 0,
   set: _set_privateStaticFieldValue
 };
diff --git a/...-plugin-proposal-private-methods/test/fixtures/static-accessors/set-only-getter/output.js b/...-plugin-proposal-private-methods/test/fixtures/static-accessors/set-only-getter/output.js
@@ -15,5 +15,5 @@ var _PRIVATE_STATIC_FIELD = {
 };
 var _privateStaticFieldValue = {
   get: _get_privateStaticFieldValue,
-  set: null
+  set: void 0
 };