Typescript: Avoid stripping class properties when a decorator is set (#…

…8238) The `babel-plugin-transform-typescript` removes class properties without value regardless if decorators are assigned to it or not.
babel · Jul 4, 2018 · 4d125c3 · 4d125c3
1 parent afa1207
commit 4d125c3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/packages/babel-plugin-transform-typescript/src/index.js b/packages/babel-plugin-transform-typescript/src/index.js
@@ -157,10 +157,6 @@ export default declare((api, { jsxPragma = "React" }) => {
 
       ClassProperty(path) {
         const { node } = path;
-        if (!node.value) {
-          path.remove();
-          return;
-        }
 
         if (node.accessibility) node.accessibility = null;
         if (node.abstract) node.abstract = null;
@@ -196,7 +192,10 @@ export default declare((api, { jsxPragma = "React" }) => {
         path.get("body.body").forEach(child => {
           if (child.isClassProperty()) {
             child.node.typeAnnotation = null;
-            if (!child.node.value) child.remove();
+
+            if (!child.node.value && !child.node.decorators) {
+              child.remove();
+            }
           }
         });
       },

diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/properties/input.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/properties/input.js
@@ -2,4 +2,6 @@ class C {
     public a?: number;
     private b: number = 0;
     readonly c!: number = 1;
+    @foo d: number;
+    @foo e: number = 3;
 }
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/properties/options.json b/packages/babel-plugin-transform-typescript/test/fixtures/class/properties/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "transform-typescript",
+    ["syntax-decorators", { "legacy": true }]
+  ]
+}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/properties/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/properties/output.js
@@ -1,4 +1,8 @@
 class C {
   b = 0;
   c = 1;
+  @foo
+  d;
+  @foo
+  e = 3;
 }