Update dev dependencies and fix linting errors (#10228)

* chore: Uppate dev dependencies

* chore: Fix lint errors

* chore: Format options.json files

* chore: Fix stupid flow errors

* Update test262 whitelist

Seems test262-stream was updated and now these tests work.

package.json

@@ -32,13 +32,13 @@
     "derequire": "^2.0.2",
     "duplicate-package-checker-webpack-plugin": "^2.1.0",
     "enhanced-resolve": "^3.0.0",
-    "eslint": "^5.16.0",
+    "eslint": "^6.0.1",
     "eslint-config-babel": "^9.0.0",
     "eslint-plugin-flowtype": "^3.8.2",
     "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-prettier": "^3.1.0",
     "fancy-log": "^1.3.3",
-    "flow-bin": "^0.94.0",
+    "flow-bin": "^0.102.0",
     "graceful-fs": "^4.1.15",
     "gulp": "^4.0.2",
     "gulp-babel": "^8.0.0",
@@ -48,11 +48,11 @@
     "gulp-rename": "^1.4.0",
     "gulp-uglify": "^3.0.2",
     "gulp-watch": "^5.0.1",
-    "husky": "^2.3.0",
+    "husky": "^3.0.0",
     "jest": "^24.8.0",
     "lerna": "^3.14.2",
     "lerna-changelog": "^0.5.0",
-    "lint-staged": "^8.1.7",
+    "lint-staged": "^9.2.0",
     "lodash": "^4.17.13",
     "merge-stream": "^1.0.1",
     "output-file-sync": "^2.0.0",

packages/babel-cli/test/index.js

@@ -92,7 +92,7 @@ const assertTest = function(stdout, stderr, opts, cwd) {
       if (
         // saveInFiles always creates an empty .babelrc, so lets exclude for now
         filename !== ".babelrc" &&
-        !opts.inFiles.hasOwnProperty(filename)
+        !Object.prototype.hasOwnProperty.call(opts.inFiles, filename)
       ) {
         const expected = opts.outFiles[filename];
         const actual = actualFiles[filename];

packages/babel-core/src/config/config-chain.js

@@ -268,13 +268,11 @@ function babelrcLoadEnabled(
   });
 }
 
-const validateConfigFile = makeWeakCache(
-  (file: ConfigFile): ValidatedFile => ({
-    filepath: file.filepath,
-    dirname: file.dirname,
-    options: validate("configfile", file.options),
-  }),
-);
+const validateConfigFile = makeWeakCache((file: ConfigFile): ValidatedFile => ({
+  filepath: file.filepath,
+  dirname: file.dirname,
+  options: validate("configfile", file.options),
+}));
 
 const validateBabelrcFile = makeWeakCache(
   (file: ConfigFile): ValidatedFile => ({
@@ -284,13 +282,11 @@ const validateBabelrcFile = makeWeakCache(
   }),
 );
 
-const validateExtendFile = makeWeakCache(
-  (file: ConfigFile): ValidatedFile => ({
-    filepath: file.filepath,
-    dirname: file.dirname,
-    options: validate("extendsfile", file.options),
-  }),
-);
+const validateExtendFile = makeWeakCache((file: ConfigFile): ValidatedFile => ({
+  filepath: file.filepath,
+  dirname: file.dirname,
+  options: validate("extendsfile", file.options),
+}));
 
 /**
  * Build a config chain for just the programmatic options passed into Babel.
@@ -549,7 +545,7 @@ function normalizeOptions(opts: ValidatedOptions): ValidatedOptions {
 
   // "sourceMap" is just aliased to sourceMap, so copy it over as
   // we merge the options together.
-  if (options.hasOwnProperty("sourceMap")) {
+  if (Object.prototype.hasOwnProperty.call(options, "sourceMap")) {
     options.sourceMaps = options.sourceMap;
     delete options.sourceMap;
   }

packages/babel-core/src/config/validation/option-assertions.js

@@ -278,7 +278,7 @@ export function assertConfigFileSearch(
   ) {
     throw new Error(
       `${msg(loc)} must be a undefined, a boolean, a string, ` +
-        `got ${JSON.stringify(value)}`,
+        `got ${JSON.stringify((value: any))}`,
     );
   }
 
@@ -302,7 +302,7 @@ export function assertBabelrcSearch(
   } else if (!checkValidTest(value)) {
     throw new Error(
       `${msg(loc)} must be a undefined, a boolean, a string/Function/RegExp ` +
-        `or an array of those, got ${JSON.stringify(value)}`,
+        `or an array of those, got ${JSON.stringify((value: any))}`,
     );
   }
   return (value: any);

packages/babel-core/src/transformation/file/generate.js

@@ -1,7 +1,7 @@
 // @flow
 
 import type { PluginPasses } from "../../config";
-import convertSourceMap, { type SourceMap } from "convert-source-map";
+import convertSourceMap, { typeof SourceMap } from "convert-source-map";
 import generate from "@babel/generator";
 
 import type File from "./file";

packages/babel-core/src/transformation/file/merge-map.js

@@ -1,6 +1,6 @@
 // @flow
 
-import type { SourceMap } from "convert-source-map";
+import typeof { SourceMap } from "convert-source-map";
 import sourceMap from "source-map";
 
 export default function mergeSourceMap(

packages/babel-core/src/transformation/index.js

@@ -1,6 +1,6 @@
 // @flow
 import traverse from "@babel/traverse";
-import type { SourceMap } from "convert-source-map";
+import typeof { SourceMap } from "convert-source-map";
 
 import type { ResolvedConfig, PluginPasses } from "../config";
 

packages/babel-generator/test/fixtures/comments/create-parenthesized-expressions/options.json

@@ -1,3 +1,3 @@
 {
-  "parserOpts": {"createParenthesizedExpressions": true}
+  "parserOpts": { "createParenthesizedExpressions": true }
 }

packages/babel-helper-create-class-features-plugin/test/fixtures/plugin-proposal-private-methods/loose-false/options.json

@@ -1,5 +1,3 @@
 {
-  "plugins": [
-    ["proposal-private-methods", { "loose": false }]
-  ]
+  "plugins": [["proposal-private-methods", { "loose": false }]]
 }

packages/babel-helper-create-class-features-plugin/test/fixtures/plugin-proposal-private-methods/loose-true/options.json

@@ -1,5 +1,3 @@
 {
-  "plugins": [
-    ["proposal-private-methods", { "loose": true }]
-  ]
+  "plugins": [["proposal-private-methods", { "loose": true }]]
 }

packages/babel-helper-fixtures/src/index.js

@@ -169,9 +169,7 @@ export default function get(entryLoc): Array<Suite> {
 
         if (minimumVersion == null) {
           throw new Error(
-            `'minNodeVersion' has invalid semver format: ${
-              taskOpts.minNodeVersion
-            }`,
+            `'minNodeVersion' has invalid semver format: ${taskOpts.minNodeVersion}`,
           );
         }
 

packages/babel-node/test/index.js

@@ -77,7 +77,7 @@ const assertTest = function(stdout, stderr, opts) {
     const actualFiles = readDir(path.join(tmpLoc));
 
     Object.keys(actualFiles).forEach(function(filename) {
-      if (!opts.inFiles.hasOwnProperty(filename)) {
+      if (!Object.prototype.hasOwnProperty.call(opts.inFiles, filename)) {
         const expected = opts.outFiles[filename];
         const actual = actualFiles[filename];
 

packages/babel-parser/src/parser/expression.js

@@ -1137,9 +1137,7 @@ export default class ExpressionParser extends LValParser {
     if (node.property.name !== propertyName || containsEsc) {
       this.raise(
         node.property.start,
-        `The only valid meta property for ${meta.name} is ${
-          meta.name
-        }.${propertyName}`,
+        `The only valid meta property for ${meta.name} is ${meta.name}.${propertyName}`,
       );
     }
 

packages/babel-parser/src/plugins/typescript/index.js

@@ -369,9 +369,8 @@ export default (superClass: Class<Parser>): Class<Parser> =>
         ) {
           throw this.unexpected(
             pattern.start,
-            `Name in a signature must be an Identifier, ObjectPattern or ArrayPattern, instead got ${
-              pattern.type
-            }`,
+            "Name in a signature must be an Identifier, ObjectPattern or ArrayPattern," +
+              `instead got ${pattern.type}`,
           );
         }
         return pattern;

packages/babel-parser/test/fixtures/core/object/invalid-escape-get/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Unexpected token, expected \",\" (1:12)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-lex-nested/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (4:6)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-lex/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (3:4)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-var-nested/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (4:6)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-var/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (3:4)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-catch-arr-destr/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (2:15)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-catch-dbl-let/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (1:35)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-catch-func/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (3:11)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-catch-obj-destr/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (2:28)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-catch-var-arr-destr/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (3:6)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-catch-var-obj-destr/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (3:6)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-class-const/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (2:6)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-class-func/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (2:9)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-class-let/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (2:4)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-class-var/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (2:4)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-func-gen/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'f' has already been declared (1:28)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-func-module/options.json

@@ -1,4 +1,4 @@
 {
   "sourceType": "module",
-  "throws":"Identifier 'foo' has already been declared (2:9)"
+  "throws": "Identifier 'foo' has already been declared (2:9)"
 }

packages/babel-parser/test/fixtures/core/scope/dupl-bind-func-var-sloppy/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (3:6)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-gen-func/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'f' has already been declared (1:28)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-let-let/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'foo' has already been declared (1:9)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-nested-let-var/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'a' has already been declared (3:8)"
-}
+}

packages/babel-parser/test/fixtures/core/scope/for-var/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Identifier 'i' has already been declared (2:8)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/468/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Binding 'eval' in strict mode (1:36)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/469/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Binding 'arguments' in strict mode (1:36)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/470/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Binding 'eval' in strict mode (1:47)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/471/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Binding 'arguments' in strict mode (1:47)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/472/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'eval' in strict mode (1:32)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/473/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'arguments' in strict mode (1:32)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/474/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'eval' in strict mode (1:34)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/475/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'eval' in strict mode (1:34)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/476/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'arguments' in strict mode (1:34)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/477/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'arguments' in strict mode (1:34)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/478/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'eval' in strict mode (1:32)"
-}
+}

packages/babel-parser/test/fixtures/core/uncategorised/479/options.json

@@ -1,3 +1,3 @@
 {
   "throws": "Assigning to 'eval' in strict mode (1:32)"
-}
+}