Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: throw expect privateIn when we see tt._in after private name
- Loading branch information
Showing
5 changed files
with
114 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
packages/babel-parser/test/fixtures/experimental/_no-plugin/private-in/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class Point { | ||
#x = 1; | ||
#y = 2; | ||
static isPoint(obj) { | ||
return #x in obj && #y in obj; | ||
} | ||
} |
6 changes: 6 additions & 0 deletions
6
packages/babel-parser/test/fixtures/experimental/_no-plugin/private-in/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"plugins": [ | ||
"classPrivateProperties" | ||
], | ||
"throws": "This experimental syntax requires enabling the parser plugin: 'privateIn' (5:14)" | ||
} |
1 change: 0 additions & 1 deletion
1
...parser/test/fixtures/experimental/class-private-properties/failure-shorthand/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
{ | ||
"throws": "Unexpected token (4:11)", | ||
"plugins": [ | ||
"classPrivateProperties" | ||
] | ||
|
89 changes: 89 additions & 0 deletions
89
...-parser/test/fixtures/experimental/class-private-properties/failure-shorthand/output.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
{ | ||
"type": "File", | ||
"start":0,"end":56,"loc":{"start":{"line":1,"column":0},"end":{"line":6,"column":1}}, | ||
"errors": [ | ||
"SyntaxError: Private names are only allowed in property accesses (`obj.#x`) or in `in` expressions (`#x in obj`) (4:13)" | ||
], | ||
"program": { | ||
"type": "Program", | ||
"start":0,"end":56,"loc":{"start":{"line":1,"column":0},"end":{"line":6,"column":1}}, | ||
"sourceType": "script", | ||
"interpreter": null, | ||
"body": [ | ||
{ | ||
"type": "ClassDeclaration", | ||
"start":0,"end":56,"loc":{"start":{"line":1,"column":0},"end":{"line":6,"column":1}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":6,"end":9,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":9},"identifierName":"Foo"}, | ||
"name": "Foo" | ||
}, | ||
"superClass": null, | ||
"body": { | ||
"type": "ClassBody", | ||
"start":10,"end":56,"loc":{"start":{"line":1,"column":10},"end":{"line":6,"column":1}}, | ||
"body": [ | ||
{ | ||
"type": "ClassPrivateProperty", | ||
"start":14,"end":17,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":5}}, | ||
"static": false, | ||
"key": { | ||
"type": "PrivateName", | ||
"start":14,"end":16,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":4}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":15,"end":16,"loc":{"start":{"line":2,"column":3},"end":{"line":2,"column":4},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
}, | ||
"value": null | ||
}, | ||
{ | ||
"type": "ClassMethod", | ||
"start":20,"end":54,"loc":{"start":{"line":3,"column":2},"end":{"line":5,"column":3}}, | ||
"static": false, | ||
"key": { | ||
"type": "Identifier", | ||
"start":20,"end":31,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":13},"identifierName":"constructor"}, | ||
"name": "constructor" | ||
}, | ||
"computed": false, | ||
"kind": "constructor", | ||
"id": null, | ||
"generator": false, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":34,"end":54,"loc":{"start":{"line":3,"column":16},"end":{"line":5,"column":3}}, | ||
"body": [ | ||
{ | ||
"type": "ExpressionStatement", | ||
"start":40,"end":50,"loc":{"start":{"line":4,"column":4},"end":{"line":4,"column":14}}, | ||
"expression": { | ||
"type": "UnaryExpression", | ||
"start":40,"end":49,"loc":{"start":{"line":4,"column":4},"end":{"line":4,"column":13}}, | ||
"operator": "delete", | ||
"prefix": true, | ||
"argument": { | ||
"type": "PrivateName", | ||
"start":47,"end":49,"loc":{"start":{"line":4,"column":11},"end":{"line":4,"column":13}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":48,"end":49,"loc":{"start":{"line":4,"column":12},"end":{"line":4,"column":13},"identifierName":"x"}, | ||
"name": "x" | ||
} | ||
} | ||
} | ||
} | ||
], | ||
"directives": [] | ||
} | ||
} | ||
] | ||
} | ||
} | ||
], | ||
"directives": [] | ||
} | ||
} |