Enable Babel e2e test for Babel 8 with ESM (#15836)

babel · Aug 3, 2023 · 565d7be · 565d7be
1 parent 87483a1
commit 565d7be
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/.github/workflows/e2e-tests-breaking-esm.yml b/.github/workflows/e2e-tests-breaking-esm.yml
@@ -46,7 +46,7 @@ jobs:
       matrix:
         # todo: verify which of these tests can be re-enabled
         project:
-          # - babel
+          - babel
           - create-react-app
           # - vue-cli
           # - jest

diff --git a/scripts/integration-tests/e2e-babel.sh b/scripts/integration-tests/e2e-babel.sh
@@ -20,19 +20,23 @@ cd ../..
 #                                   TEST                                       #
 #==============================================================================#
 
-if [ "$BABEL_8_BREAKING" = true ] ; then
-  # This option is removed in Babel 8
-  sed -i 's/allowDeclareFields: true,\?/\/* allowDeclareFields: true *\//g' babel.config.js
-fi
-
 startLocalRegistry "$PWD"/scripts/integration-tests/verdaccio-config.yml
 
 # We only bump dependencies in the top-level package.json, because workspaces
 # already use the workspace: protocol so will get the version in the monorepo
 # and not from npm.
 node "$PWD"/scripts/integration-tests/utils/bump-babel-dependencies.js
+export YARN_ENABLE_IMMUTABLE_INSTALLS=false
+
+if [ "$BABEL_8_BREAKING" = true ] ; then
+  # This option is removed in Babel 8
+  sed -i 's/allowDeclareFields: true,\?/\/* allowDeclareFields: true *\//g' babel.config.js
+
+  # Babel 8 only supports ESM
+  make use-esm
+fi
 
 # Build and test
-YARN_ENABLE_IMMUTABLE_INSTALLS=false make -j test-ci
+make -j test-ci
 
 cleanup