Skip to content

Commit

Permalink
[parser] enable dynamic import by default (#10843)
Browse files Browse the repository at this point in the history
* [parser] enable dynamic import by default

* chore: add back babel-core api test
  • Loading branch information
AbdulAli19 authored and nicolo-ribaudo committed Jan 10, 2020
1 parent 7bc22e4 commit 5b907e9
Show file tree
Hide file tree
Showing 45 changed files with 8 additions and 41 deletions.
6 changes: 3 additions & 3 deletions packages/babel-core/test/api.js
Expand Up @@ -760,11 +760,11 @@ describe("api", function() {
options,
function(err) {
expect(err.message).toMatch(
"Support for the experimental syntax 'dynamicImport' isn't currently enabled (1:9)",
"Support for the experimental syntax 'pipelineOperator' isn't currently enabled (1:3):",
);
expect(err.message).toMatch(
"Add @babel/plugin-syntax-dynamic-import (https://git.io/vb4Sv) to the " +
"'plugins' section of your Babel config to enable parsing.",
"Add @babel/plugin-proposal-pipeline-operator (https://git.io/vb4SU) to the " +
"'plugins' section of your Babel config to enable transformation.",
);
done();
},
Expand Down
@@ -1 +1 @@
var $ = import("jquery");
a |> b
2 changes: 0 additions & 2 deletions packages/babel-parser/src/parser/expression.js
Expand Up @@ -922,8 +922,6 @@ export default class ExpressionParser extends LValParser {
return this.parseImportMetaProperty(node);
}

this.expectPlugin("dynamicImport", node.start);

if (!this.match(tt.parenL)) {
this.raise(
this.state.lastTokStart,
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

@@ -1,4 +1,4 @@
{
"plugins": ["dynamicImport", "importMeta"],
"plugins": ["importMeta"],
"sourceType": "script"
}
@@ -1,4 +1,4 @@
{
"sourceType": "module",
"plugins": ["dynamicImport", "importMeta"]
"plugins": ["importMeta"]
}
@@ -1,4 +1,4 @@
{
"sourceType": "module",
"plugins": ["dynamicImport", "importMeta"]
"plugins": ["importMeta"]
}
@@ -1,4 +1,4 @@
{
"sourceType": "module",
"plugins": ["dynamicImport", "importMeta"]
"plugins": ["importMeta"]
}

0 comments on commit 5b907e9

Please sign in to comment.