Skip to content

Commit

Permalink
[babel-cli] Don't fail when chmod throws an error (#12846)
Browse files Browse the repository at this point in the history
Co-authored-by: Nicol貌 Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
  • Loading branch information
3 people committed Feb 22, 2021
1 parent c294de3 commit 5bec993
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
6 changes: 5 additions & 1 deletion packages/babel-cli/src/babel/util.js
Expand Up @@ -6,7 +6,11 @@ import path from "path";
import fs from "fs";

export function chmod(src: string, dest: string): void {
fs.chmodSync(dest, fs.statSync(src).mode);
try {
fs.chmodSync(dest, fs.statSync(src).mode);
} catch (err) {
console.warn(`Cannot change permissions of ${dest}`);
}
}

type ReaddirFilter = (filename: string) => boolean;
Expand Down
13 changes: 13 additions & 0 deletions packages/babel-cli/test/index.js
Expand Up @@ -7,6 +7,7 @@ const escapeRegExp = require("lodash/escapeRegExp");
const merge = require("lodash/merge");
const path = require("path");
const fs = require("fs");
const { chmod } = require("../lib/babel/util");

const fixtureLoc = path.join(__dirname, "fixtures");
const tmpLoc = path.join(__dirname, "tmp");
Expand Down Expand Up @@ -269,3 +270,15 @@ fs.readdirSync(fixtureLoc).forEach(function (binName) {
});
});
});

describe("util.js", () => {
describe("chmod", () => {
it("should warn the user if chmod fails", () => {
const spyConsoleWarn = jest.spyOn(console, "warn");
// should expect a string as first argument
chmod(100, "file.js");
expect(spyConsoleWarn).toHaveBeenCalledTimes(1);
spyConsoleWarn.mockRestore();
});
});
});

0 comments on commit 5bec993

Please sign in to comment.