Fix computed key case

babel · Nov 27, 2023 · 604a3d6 · 604a3d6
1 parent a7c0739
commit 604a3d6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/eslint/babel-eslint-plugin/src/rules/no-undef.cjs b/eslint/babel-eslint-plugin/src/rules/no-undef.cjs
@@ -8,13 +8,15 @@ const rule = new eslint.Linter().getRules().get("no-undef");
  * @param  {ASTNode}  node CallExpression node
  * @returns {Boolean} Returns true if the node is under a decorator.
  */
-function isAccessorField(node) {
+function isAccessorFieldName(node) {
   return (
-    node.parent.type === "ClassAccessorProperty" && node.parent.key === node
+    node.parent.type === "ClassAccessorProperty" &&
+    node.parent.key === node &&
+    !node.parent.computed
   );
 }
 
 module.exports = ruleComposer.filterReports(
   rule,
-  problem => !isAccessorField(problem.node),
+  problem => !isAccessorFieldName(problem.node),
 );
diff --git a/eslint/babel-eslint-plugin/test/rules/no-undef.js b/eslint/babel-eslint-plugin/test/rules/no-undef.js
@@ -16,5 +16,9 @@ ruleTester.run("@babel/no-undef", rule, {
       code: "{ using x = 2; } x;",
       errors: [{ message: "'x' is not defined." }],
     },
+    {
+      code: "class MyClass { accessor [x] = 2 }",
+      errors: [{ message: "'x' is not defined." }],
+    },
   ],
 });