Skip to content

Commit

Permalink
Enable new rule
Browse files Browse the repository at this point in the history
  • Loading branch information
kaicataldo committed May 12, 2020
1 parent a30fb7a commit 62817aa
Show file tree
Hide file tree
Showing 6 changed files with 43 additions and 10 deletions.
23 changes: 20 additions & 3 deletions .eslintrc.js
Expand Up @@ -2,7 +2,13 @@ const path = require("path");

module.exports = {
root: true,
plugins: ["prettier", "@babel/development", "import", "jest"],
plugins: [
"import",
"jest",
"prettier",
"@babel/development",
"@babel/development-internal",
],
// replace it by `@babel/internal` when `@babel/eslint-config-internal` is published
extends: path.resolve(__dirname, "eslint/babel-eslint-config-internal"),
rules: {
Expand Down Expand Up @@ -44,8 +50,8 @@ module.exports = {
"jest/no-identical-title": "off",
"jest/no-standalone-expect": "off",
"jest/no-test-callback": "off",
"jest/valid-describe": "off"
}
"jest/valid-describe": "off",
},
},
{
files: ["packages/babel-plugin-*/src/index.js"],
Expand All @@ -55,5 +61,16 @@ module.exports = {
eqeqeq: ["error", "always", { null: "ignore" }],
},
},
{
files: ["packages/babel-parser/src/**/*.js"],
rules: {
"@babel/development-internal/dry-error-messages": [
"error",
{
errorModule: "packages/babel-parser/src/parser/location.js",
},
],
},
},
],
};
@@ -1,6 +1,6 @@
import dryErrorMessages from "./rules/dry-error-messages";

export default {
module.exports = {
rules: {
"dry-error-messages": dryErrorMessages,
},
Expand Down
Expand Up @@ -99,16 +99,28 @@ export default {
const filename = getFilename();
const importedBindings = new Set();

if (!path.isAbsolute(errorModule)) {
report({ message: "`errorModule` must be an absolute path." });
}

return {
// Check imports up front so that we don't have to check them for every ThrowStatement.
ImportDeclaration(node) {
if (filename === errorModule) {
return;
}

if (isErrorModule(errorModule, filename, node.source.value)) {
for (const spec of node.specifiers) {
importedBindings.add(spec);
}
}
},
"ThrowStatement > CallExpression[callee.type='MemberExpression']"(node) {
if (filename === errorModule) {
return;
}

if (
node.callee.object.type !== "ThisExpression" ||
node.callee.property.name !== "raise"
Expand Down
2 changes: 1 addition & 1 deletion eslint/babel-eslint-plugin-development/src/index.js
Expand Up @@ -2,7 +2,7 @@ import noDeprecatedClone from "./rules/no-deprecated-clone";
import noUndefinedIdentifier from "./rules/no-undefined-identifier";
import pluginName from "./rules/plugin-name";

export default {
module.exports = {
rules: {
"no-deprecated-clone": noDeprecatedClone,
"no-undefined-identifier": noUndefinedIdentifier,
Expand Down
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -13,7 +13,8 @@
"devDependencies": {
"@babel/cli": "^7.8.4",
"@babel/core": "^7.9.6",
"@babel/eslint-plugin-development": "^1.0.1",
"@babel/eslint-plugin-development": "link:./eslint/babel-eslint-plugin-development",
"@babel/eslint-plugin-development-internal": "link:./eslint/babel-eslint-plugin-development-internal",
"@babel/plugin-proposal-class-properties": "^7.8.3",
"@babel/plugin-proposal-dynamic-import": "^7.8.3",
"@babel/plugin-proposal-export-namespace-from": "^7.8.3",
Expand Down
11 changes: 7 additions & 4 deletions yarn.lock
Expand Up @@ -56,10 +56,13 @@
semver "^5.4.1"
source-map "^0.5.0"

"@babel/eslint-plugin-development@^1.0.1":
version "1.0.1"
resolved "https://registry.yarnpkg.com/@babel/eslint-plugin-development/-/eslint-plugin-development-1.0.1.tgz#1f5206ae95795db09b65e7dbc2b158d66497a44c"
integrity sha512-ioEhN8HgKr4Yx8ef+XryNpKN4FimSFceb0qVVxvoUzpFn3xyq17MlY5AquEqtXObE7Nu7WKq7QL9INzjCrugyw==
"@babel/eslint-plugin-development-internal@link:./eslint/babel-eslint-plugin-development-internal":
version "0.0.0"
uid ""

"@babel/eslint-plugin-development@link:./eslint/babel-eslint-plugin-development":
version "0.0.0"
uid ""

"@babel/generator@^7.4.0", "@babel/generator@^7.9.6":
version "7.9.6"
Expand Down

0 comments on commit 62817aa

Please sign in to comment.