corejs.proposals should not imply shipped proposals

babel · Feb 22, 2020 · 63e662d · 63e662d
1 parent 5febab5
commit 63e662d
Show file tree

Hide file tree

Showing 13 changed files with 5 additions and 18 deletions.
diff --git a/packages/babel-preset-env/src/normalize-options.js b/packages/babel-preset-env/src/normalize-options.js
@@ -267,12 +267,11 @@ export default function normalizeOptions(opts: Options) {
 
   checkDuplicateIncludeExcludes(include, exclude);
 
-  const shippedProposals =
-    validateBoolOption(
-      TopLevelOptions.shippedProposals,
-      opts.shippedProposals,
-      false,
-    ) || corejs.proposals;
+  const shippedProposals = validateBoolOption(
+    TopLevelOptions.shippedProposals,
+    opts.shippedProposals,
+    false,
+  );
 
   return {
     configPath: validateConfigPathOption(opts.configPath),

diff --git a/packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals-chrome-71/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals-chrome-71/stdout.txt
@@ -14,7 +14,6 @@ Using plugins:
   syntax-optional-catch-binding { "chrome":"71" }
   syntax-async-generators { "chrome":"71" }
   syntax-object-rest-spread { "chrome":"71" }
-  proposal-numeric-separator { "chrome":"71" }
   transform-modules-commonjs { "chrome":"71" }
   proposal-dynamic-import { "chrome":"71" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals/stdout.txt
@@ -37,7 +37,6 @@ Using plugins:
   transform-typeof-symbol {}
   transform-new-target {}
   transform-regenerator {}
-  proposal-numeric-separator {}
   transform-member-expression-literals {}
   transform-property-literals {}
   transform-reserved-words {}

diff --git a/packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals-chrome-71/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals-chrome-71/stdout.txt
@@ -14,7 +14,6 @@ Using plugins:
   syntax-optional-catch-binding { "chrome":"71" }
   syntax-async-generators { "chrome":"71" }
   syntax-object-rest-spread { "chrome":"71" }
-  proposal-numeric-separator { "chrome":"71" }
   transform-modules-commonjs { "chrome":"71" }
   proposal-dynamic-import { "chrome":"71" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals/stdout.txt
@@ -37,7 +37,6 @@ Using plugins:
   transform-typeof-symbol {}
   transform-new-target {}
   transform-regenerator {}
-  proposal-numeric-separator {}
   transform-member-expression-literals {}
   transform-property-literals {}
   transform-reserved-words {}

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-1/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-1/stdout.txt
@@ -40,7 +40,6 @@ Using plugins:
   transform-typeof-symbol { "ie":"11" }
   transform-new-target { "ie":"11" }
   transform-regenerator { "firefox":"50", "ie":"11" }
-  proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
   transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
   proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-2/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-2/stdout.txt
@@ -40,7 +40,6 @@ Using plugins:
   transform-typeof-symbol { "ie":"11" }
   transform-new-target { "ie":"11" }
   transform-regenerator { "firefox":"50", "ie":"11" }
-  proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
   transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
   proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-1/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-1/stdout.txt
@@ -14,7 +14,6 @@ Using plugins:
   syntax-optional-catch-binding { "chrome":"71" }
   syntax-async-generators { "chrome":"71" }
   syntax-object-rest-spread { "chrome":"71" }
-  proposal-numeric-separator { "chrome":"71" }
   transform-modules-commonjs { "chrome":"71" }
   proposal-dynamic-import { "chrome":"71" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-2/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-2/stdout.txt
@@ -14,7 +14,6 @@ Using plugins:
   syntax-optional-catch-binding { "chrome":"71" }
   syntax-async-generators { "chrome":"71" }
   syntax-object-rest-spread { "chrome":"71" }
-  proposal-numeric-separator { "chrome":"71" }
   transform-modules-commonjs { "chrome":"71" }
   proposal-dynamic-import { "chrome":"71" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-1/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-1/stdout.txt
@@ -40,7 +40,6 @@ Using plugins:
   transform-typeof-symbol { "ie":"11" }
   transform-new-target { "ie":"11" }
   transform-regenerator { "firefox":"50", "ie":"11" }
-  proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
   transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
   proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-2/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-2/stdout.txt
@@ -40,7 +40,6 @@ Using plugins:
   transform-typeof-symbol { "ie":"11" }
   transform-new-target { "ie":"11" }
   transform-regenerator { "firefox":"50", "ie":"11" }
-  proposal-numeric-separator { "chrome":"52", "firefox":"50", "ie":"11" }
   transform-modules-commonjs { "chrome":"52", "firefox":"50", "ie":"11" }
   proposal-dynamic-import { "chrome":"52", "firefox":"50", "ie":"11" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-1/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-1/stdout.txt
@@ -14,7 +14,6 @@ Using plugins:
   syntax-optional-catch-binding { "chrome":"71" }
   syntax-async-generators { "chrome":"71" }
   syntax-object-rest-spread { "chrome":"71" }
-  proposal-numeric-separator { "chrome":"71" }
   transform-modules-commonjs { "chrome":"71" }
   proposal-dynamic-import { "chrome":"71" }
 

diff --git a/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-2/stdout.txt b/packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-2/stdout.txt
@@ -14,7 +14,6 @@ Using plugins:
   syntax-optional-catch-binding { "chrome":"71" }
   syntax-async-generators { "chrome":"71" }
   syntax-object-rest-spread { "chrome":"71" }
-  proposal-numeric-separator { "chrome":"71" }
   transform-modules-commonjs { "chrome":"71" }
   proposal-dynamic-import { "chrome":"71" }