Use file extension to signal skipping

babel · Nov 24, 2021 · 63f5f79 · 63f5f79
1 parent c9123d3
commit 63f5f79
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 67 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -1,4 +1,5 @@
 const supportsESM = parseInt(process.versions.node) >= 12;
+const isPublishBundle = process.env.IS_PUBLISH;
 
 module.exports = {
   collectCoverageFrom: [
@@ -23,6 +24,9 @@ module.exports = {
     "<rootDir>/build/",
     "<rootDir>/.history/", // local directory for VSCode Extension - https://marketplace.visualstudio.com/items?itemName=xyz.local-history
     "_browser\\.js",
+    // Some tests require internal files of bundled packages, which are not available
+    // in production builds. They are marked using the .skip-bundled.js extension.
+    ...(isPublishBundle ? ["\\.skip-bundled\\.js$"] : []),
   ],
   testEnvironment: "node",
   setupFilesAfterEnv: ["<rootDir>/test/testSetupFile.js"],

diff --git a/...babel-parser/test/unit/tokenizer/types.js → ...test/unit/tokenizer/types.skip-bundled.js b/...babel-parser/test/unit/tokenizer/types.js → ...test/unit/tokenizer/types.skip-bundled.js
@@ -1,13 +1,6 @@
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("token types", () => {
-  let tt, tokenOperatorPrecedence;
-  beforeAll(async () => {
-    ({ tt, tokenOperatorPrecedence } = await import(
-      "../../../lib/tokenizer/types.js"
-    ));
-  });
+import { tt, tokenOperatorPrecedence } from "../../../lib/tokenizer/types.js";
 
+describe("token types", () => {
   it("should check if the binOp for relational === in", () => {
     expect(tokenOperatorPrecedence(tt.relational)).toEqual(
       tokenOperatorPrecedence(tt._in),

diff --git a/...babel-parser/test/unit/util/identifier.js → ...test/unit/util/identifier.skip-bundled.js b/...babel-parser/test/unit/util/identifier.js → ...test/unit/util/identifier.skip-bundled.js
@@ -1,13 +1,9 @@
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("identifier", () => {
-  let isKeyword, keywordRelationalOperator;
-  beforeAll(async () => {
-    ({ isKeyword, keywordRelationalOperator } = await import(
-      "../../../lib/util/identifier.js"
-    ));
-  });
+import {
+  isKeyword,
+  keywordRelationalOperator,
+} from "../../../lib/util/identifier.js";
 
+describe("identifier", () => {
   describe("isKeyword", () => {
     it("break is a keyword", () => {
       expect(isKeyword("break")).toBe(true);

diff --git a/...s/babel-parser/test/unit/util/location.js → ...r/test/unit/util/location.skip-bundled.js b/...s/babel-parser/test/unit/util/location.js → ...r/test/unit/util/location.skip-bundled.js
@@ -1,11 +1,6 @@
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("getLineInfo", () => {
-  let getLineInfo;
-  beforeAll(async () => {
-    ({ getLineInfo } = await import("../../../lib/util/location.js"));
-  });
+import { getLineInfo } from "../../../lib/util/location.js";
 
+describe("getLineInfo", () => {
   const input = "a\nb\nc\nd\ne\nf\ng\nh\ni";
 
   it("reports correct position", () => {

diff --git a/...-in-function-expression/test/util.test.js → ...tion-expression/test/util.skip-bundled.js b/...-in-function-expression/test/util.test.js → ...tion-expression/test/util.skip-bundled.js
@@ -1,4 +1,5 @@
 import { parseSync, traverse } from "@babel/core";
+import { shouldTransform } from "../lib/util.ts";
 
 function getPath(input, parserOpts = {}) {
   let targetPath;
@@ -18,14 +19,7 @@ function getPath(input, parserOpts = {}) {
   return targetPath;
 }
 
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("shouldTransform", () => {
-  let shouldTransform;
-  beforeAll(async () => {
-    ({ shouldTransform } = await import("../lib/util.js"));
-  });
-
+describe("shouldTransform", () => {
   const positiveCases = [
     "(function a([a]) {})",
     "({ b: function a([a]) {} })",

diff --git a/...rs-in-optional-chaining/test/util.test.js → ...tional-chaining/test/util.skip-bundled.js b/...rs-in-optional-chaining/test/util.test.js → ...tional-chaining/test/util.skip-bundled.js
@@ -1,4 +1,5 @@
 import { parseSync, traverse } from "@babel/core";
+import { shouldTransform } from "../lib/util.ts";
 
 function getPath(input, parserOpts = {}) {
   let targetPath;
@@ -19,14 +20,7 @@ function getPath(input, parserOpts = {}) {
   return targetPath;
 }
 
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("shouldTransform", () => {
-  let shouldTransform;
-  beforeAll(async () => {
-    ({ shouldTransform } = await import("../lib/util.js"));
-  });
-
+describe("shouldTransform", () => {
   const positiveCases = [
     "fn?.(...[], 0)",
     "fn?.(...[], ...[])",

diff --git a/...posal-optional-chaining/test/util.test.js → ...tional-chaining/test/util.skip-bundled.js b/...posal-optional-chaining/test/util.test.js → ...tional-chaining/test/util.skip-bundled.js
@@ -1,3 +1,4 @@
+import { willPathCastToBoolean } from "../lib/util.js";
 import { parseSync, traverse } from "@babel/core";
 
 function getPath(input, parserOpts) {
@@ -12,14 +13,7 @@ function getPath(input, parserOpts) {
   return targetPath;
 }
 
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("willPathCastToBoolean", () => {
-  let willPathCastToBoolean;
-  beforeAll(async () => {
-    ({ willPathCastToBoolean } = await import("../lib/util.js"));
-  });
-
+describe("willPathCastToBoolean", () => {
   const positiveCases = [
     "if(a?.b) {}",
     "while(a?.b) {}",

diff --git a/...eset-react/test/normalize-options.spec.js → ...ct/test/normalize-options.skip-bundled.js b/...eset-react/test/normalize-options.spec.js → ...ct/test/normalize-options.skip-bundled.js
@@ -1,13 +1,6 @@
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("normalize options", () => {
-  let normalizeOptions;
-  beforeAll(async () => {
-    ({ default: normalizeOptions } = await import(
-      "../lib/normalize-options.js"
-    ));
-  });
+import normalizeOptions from "../lib/normalize-options.js";
 
+describe("normalize options", () => {
   (process.env.BABEL_8_BREAKING ? describe : describe.skip)("Babel 8", () => {
     it("should throw on unknown options", () => {
       expect(() => normalizeOptions({ throwIfNamespaces: true })).toThrowError(

diff --git a/...typescript/test/normalize-options.spec.js → ...pt/test/normalize-options.skip-bundled.js b/...typescript/test/normalize-options.spec.js → ...pt/test/normalize-options.skip-bundled.js
@@ -1,13 +1,6 @@
-const describeSkipPublish = process.env.IS_PUBLISH ? describe.skip : describe;
-
-describeSkipPublish("normalize options", () => {
-  let normalizeOptions;
-  beforeAll(async () => {
-    ({ default: normalizeOptions } = await import(
-      "../lib/normalize-options.js"
-    ));
-  });
+import normalizeOptions from "../lib/normalize-options.js";
 
+describe("normalize options", () => {
   (process.env.BABEL_8_BREAKING ? describe : describe.skip)("Babel 8", () => {
     it("should throw on unknown options", () => {
       expect(() => normalizeOptions({ allowNamespace: true })).toThrowError(