fix: add missing available plugins to babel-preset-env-standalone (#1…

…0732) * fix: add missing available plugins to babel-preset-env-standalone * skip available-plugins test in CI coverage test
babel · Nov 18, 2019 · 6ba1131 · 6ba1131
1 parent a502d88
commit 6ba1131
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 1 deletion.
diff --git a/packages/babel-preset-env-standalone/package.json b/packages/babel-preset-env-standalone/package.json
@@ -14,10 +14,13 @@
   "devDependencies": {
     "@babel/plugin-proposal-dynamic-import": "^7.7.0",
     "@babel/plugin-proposal-json-strings": "^7.0.0",
+    "@babel/plugin-syntax-json-strings": "^7.2.0",
+    "@babel/plugin-syntax-top-level-await": "^7.7.0",
     "@babel/plugin-transform-named-capturing-groups-regex": "^7.7.0",
     "@babel/plugin-transform-new-target": "^7.4.4",
     "@babel/preset-env": "^7.7.1",
-    "@babel/standalone": "^7.7.3"
+    "@babel/standalone": "^7.7.3",
+    "lodash": "^4.17.13"
   },
   "keywords": [
     "babel",

diff --git a/packages/babel-preset-env-standalone/src/available-plugins.js b/packages/babel-preset-env-standalone/src/available-plugins.js
@@ -5,6 +5,8 @@ const notIncludedPlugins = {
   "transform-new-target": require("@babel/plugin-transform-new-target"),
   "proposal-json-strings": require("@babel/plugin-proposal-json-strings"),
   "proposal-dynamic-import": require("@babel/plugin-proposal-dynamic-import"),
+  "syntax-json-strings": require("@babel/plugin-syntax-json-strings"),
+  "syntax-top-level-await": require("@babel/plugin-syntax-top-level-await"),
 };
 
 Object.keys(notIncludedPlugins).forEach(pluginName => {

diff --git a/packages/babel-preset-env-standalone/test/available-plugins.js b/packages/babel-preset-env-standalone/test/available-plugins.js
@@ -0,0 +1,19 @@
+import expectedAvailablePlugins from "@babel/preset-env/lib/available-plugins";
+import difference from "lodash/difference";
+
+// build-babel-preset-env-standalone in CI coverage tests is skipped, so we skip this test as well
+(process.env.TEST_TYPE === "cov" ? describe.skip : describe)(
+  "available-plugins",
+  () => {
+    const actualAvailablePlugins = require("../lib/available-plugins").default;
+    it("should be a superset of available-plugins in @babel/preset-env", () => {
+      const expectedPluginList = Object.keys(expectedAvailablePlugins);
+      expectedPluginList.sort();
+
+      const actualPluginList = Object.keys(actualAvailablePlugins);
+      actualPluginList.sort();
+      // If this test is failed, add the missing plugins to ./src/available-plugins
+      expect(difference(expectedPluginList, actualPluginList)).toEqual([]);
+    });
+  },
+);
diff --git a/packages/babel-preset-env-standalone/test/babel-preset-env.js b/packages/babel-preset-env-standalone/test/babel-preset-env.js
@@ -1,3 +1,4 @@
+// build-babel-standalone in CI coverage tests is skipped, so we skip this test as well
 (process.env.TEST_TYPE === "cov" ? describe.skip : describe)(
   "babel-preset-env-standalone",
   () => {