Fixed issue with programPath.scope.references not being registered ba…

…ck correctly after scope re-crawling
babel · Mar 23, 2020 · 6c5b35d · 6c5b35d
1 parent 9b976b2
commit 6c5b35d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/babel-traverse/src/scope/index.js b/packages/babel-traverse/src/scope/index.js
@@ -609,6 +609,8 @@ export default class Scope {
     const ids = path.getOuterBindingIdentifiers(true);
 
     for (const name of Object.keys(ids)) {
+      parent.references[name] = true;
+
       for (const id of (ids[name]: Array<Object>)) {
         const local = this.getOwnBinding(name);
 
@@ -620,8 +622,6 @@ export default class Scope {
           this.checkBlockScopedCollisions(local, kind, name, id);
         }
 
-        parent.references[name] = true;
-
         // A redeclaration of an existing variable is a modification
         if (local) {
           this.registerConstantViolation(bindingPath);

diff --git a/packages/babel-traverse/test/scope.js b/packages/babel-traverse/test/scope.js
@@ -303,6 +303,15 @@ describe("scope", () => {
 
       expect(path.scope.bindings.a).toBe(path.get("body[0]").scope.bindings.a);
     });
+
+    it("references after re-crawling", function() {
+      const path = getPath("function Foo() { var jsx; }");
+
+      path.scope.crawl();
+      path.scope.crawl();
+
+      expect(path.scope.references.jsx).toBeTruthy();
+    });
   });
 
   describe("duplicate bindings", () => {