Skip to content

Commit

Permalink
Extract resolveFromPossibleNames to remove duplicated logic
Browse files Browse the repository at this point in the history
"DRY"s the duplicated algorithm in resolvePlugin and resolvePreset
  • Loading branch information
rmacklin committed Oct 16, 2016
1 parent 4ea1007 commit 6ec93d7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
@@ -0,0 +1,5 @@
import resolve from "./resolve";

export default function resolveFromPossibleNames(possibleNames: Array<string>, dirname: string): ?string {
return possibleNames.reduce((accum, curr) => accum || resolve(curr, dirname), null);
}
4 changes: 2 additions & 2 deletions packages/babel-core/src/helpers/resolve-plugin.js
@@ -1,6 +1,6 @@
import resolve from "./resolve";
import resolveFromPossibleNames from "./resolve-from-possible-names";
import getPossiblePluginNames from "./get-possible-plugin-names";

export default function resolvePlugin(pluginName: string, dirname: string = process.cwd()): ?string {
return getPossiblePluginNames(pluginName).reduce((accum, curr) => accum || resolve(curr, dirname), null);
return resolveFromPossibleNames(getPossiblePluginNames(pluginName), dirname);
}
4 changes: 2 additions & 2 deletions packages/babel-core/src/helpers/resolve-preset.js
@@ -1,6 +1,6 @@
import resolve from "./resolve";
import resolveFromPossibleNames from "./resolve-from-possible-names";
import getPossiblePresetNames from "./get-possible-preset-names";

export default function resolvePreset(presetName: string, dirname: string = process.cwd()): ?string {
return getPossiblePresetNames(presetName).reduce((accum, curr) => accum || resolve(curr, dirname), null);
return resolveFromPossibleNames(getPossiblePresetNames(presetName), dirname);
}

0 comments on commit 6ec93d7

Please sign in to comment.