Implement setComputedProperties assumption (#12490)

babel · Jan 24, 2021 · 7057f03 · 7057f03
1 parent f69e918
commit 7057f03
Show file tree

Hide file tree

Showing 30 changed files with 21 additions and 2 deletions.
diff --git a/packages/babel-core/src/config/validation/options.js b/packages/babel-core/src/config/validation/options.js
@@ -335,6 +335,7 @@ export const assumptionsNames = new Set<string>([
   "ignoreToPrimitiveHint",
   "mutableTemplateObject",
   "setClassMethods",
+  "setComputedProperties",
   "setPublicClassFields",
 ]);
 

diff --git a/packages/babel-plugin-transform-computed-properties/src/index.js b/packages/babel-plugin-transform-computed-properties/src/index.js
@@ -4,8 +4,10 @@ import { template, types as t } from "@babel/core";
 export default declare((api, options) => {
   api.assertVersion(7);
 
-  const { loose } = options;
-  const pushComputedProps = loose
+  const setComputedProperties =
+    api.assumption("setComputedProperties") ?? options.loose;
+
+  const pushComputedProps = setComputedProperties
     ? pushComputedPropsLoose
     : pushComputedPropsSpec;
 

diff --git a/...es/test/fixtures/loose/accessors/input.js → ...-setComputedProperties/accessors/input.js b/...es/test/fixtures/loose/accessors/input.js → ...-setComputedProperties/accessors/input.js
diff --git a/...s/test/fixtures/loose/accessors/output.js → ...setComputedProperties/accessors/output.js b/...s/test/fixtures/loose/accessors/output.js → ...setComputedProperties/accessors/output.js
diff --git a/...ies/test/fixtures/loose/argument/input.js → ...n-setComputedProperties/argument/input.js b/...ies/test/fixtures/loose/argument/input.js → ...n-setComputedProperties/argument/input.js
diff --git a/...es/test/fixtures/loose/argument/output.js → ...-setComputedProperties/argument/output.js b/...es/test/fixtures/loose/argument/output.js → ...-setComputedProperties/argument/output.js
diff --git a/...s/test/fixtures/loose/assignment/input.js → ...setComputedProperties/assignment/input.js b/...s/test/fixtures/loose/assignment/input.js → ...setComputedProperties/assignment/input.js
diff --git a/.../test/fixtures/loose/assignment/output.js → ...etComputedProperties/assignment/output.js b/.../test/fixtures/loose/assignment/output.js → ...etComputedProperties/assignment/output.js
diff --git a/...rties/test/fixtures/loose/coerce/input.js → ...ion-setComputedProperties/coerce/input.js b/...rties/test/fixtures/loose/coerce/input.js → ...ion-setComputedProperties/coerce/input.js
diff --git a/...ties/test/fixtures/loose/coerce/output.js → ...on-setComputedProperties/coerce/output.js b/...ties/test/fixtures/loose/coerce/output.js → ...on-setComputedProperties/coerce/output.js
diff --git a/...rties/test/fixtures/loose/method/input.js → ...ion-setComputedProperties/method/input.js b/...rties/test/fixtures/loose/method/input.js → ...ion-setComputedProperties/method/input.js
diff --git a/...ties/test/fixtures/loose/method/output.js → ...on-setComputedProperties/method/output.js b/...ties/test/fixtures/loose/method/output.js → ...on-setComputedProperties/method/output.js
diff --git a/...erties/test/fixtures/loose/mixed/input.js → ...tion-setComputedProperties/mixed/input.js b/...erties/test/fixtures/loose/mixed/input.js → ...tion-setComputedProperties/mixed/input.js
diff --git a/...rties/test/fixtures/loose/mixed/output.js → ...ion-setComputedProperties/mixed/output.js b/...rties/test/fixtures/loose/mixed/output.js → ...ion-setComputedProperties/mixed/output.js
diff --git a/...ies/test/fixtures/loose/multiple/input.js → ...n-setComputedProperties/multiple/input.js b/...ies/test/fixtures/loose/multiple/input.js → ...n-setComputedProperties/multiple/input.js
diff --git a/...es/test/fixtures/loose/multiple/output.js → ...-setComputedProperties/multiple/output.js b/...es/test/fixtures/loose/multiple/output.js → ...-setComputedProperties/multiple/output.js
diff --git a/...transform-computed-properties/test/fixtures/assumption-setComputedProperties/options.json b/...transform-computed-properties/test/fixtures/assumption-setComputedProperties/options.json
@@ -0,0 +1,9 @@
+{
+  "plugins": [
+    "external-helpers",
+    "transform-computed-properties"
+  ],
+  "assumptions": {
+    "setComputedProperties": true
+  }
+}
diff --git a/...rties/test/fixtures/loose/single/input.js → ...ion-setComputedProperties/single/input.js b/...rties/test/fixtures/loose/single/input.js → ...ion-setComputedProperties/single/input.js
diff --git a/...ties/test/fixtures/loose/single/output.js → ...on-setComputedProperties/single/output.js b/...ties/test/fixtures/loose/single/output.js → ...on-setComputedProperties/single/output.js
diff --git a/...erties/test/fixtures/loose/symbol/exec.js → ...tion-setComputedProperties/symbol/exec.js b/...erties/test/fixtures/loose/symbol/exec.js → ...tion-setComputedProperties/symbol/exec.js
diff --git a/...rties/test/fixtures/loose/symbol/input.js → ...ion-setComputedProperties/symbol/input.js b/...rties/test/fixtures/loose/symbol/input.js → ...ion-setComputedProperties/symbol/input.js
diff --git a/...ties/test/fixtures/loose/symbol/output.js → ...on-setComputedProperties/symbol/output.js b/...ties/test/fixtures/loose/symbol/output.js → ...on-setComputedProperties/symbol/output.js
diff --git a/...perties/test/fixtures/loose/this/input.js → ...ption-setComputedProperties/this/input.js b/...perties/test/fixtures/loose/this/input.js → ...ption-setComputedProperties/this/input.js
diff --git a/...erties/test/fixtures/loose/this/output.js → ...tion-setComputedProperties/this/output.js b/...erties/test/fixtures/loose/this/output.js → ...tion-setComputedProperties/this/output.js
diff --git a/...operties/test/fixtures/loose/two/input.js → ...mption-setComputedProperties/two/input.js b/...operties/test/fixtures/loose/two/input.js → ...mption-setComputedProperties/two/input.js
diff --git a/...perties/test/fixtures/loose/two/output.js → ...ption-setComputedProperties/two/output.js b/...perties/test/fixtures/loose/two/output.js → ...ption-setComputedProperties/two/output.js
diff --git a/...ies/test/fixtures/loose/variable/input.js → ...n-setComputedProperties/variable/input.js b/...ies/test/fixtures/loose/variable/input.js → ...n-setComputedProperties/variable/input.js
diff --git a/...es/test/fixtures/loose/variable/output.js → ...-setComputedProperties/variable/output.js b/...es/test/fixtures/loose/variable/output.js → ...-setComputedProperties/variable/output.js
diff --git a/...l-plugin-transform-computed-properties/test/fixtures/loose/setComputedProperties/input.js b/...l-plugin-transform-computed-properties/test/fixtures/loose/setComputedProperties/input.js
@@ -0,0 +1,4 @@
+var obj = {
+  ["x" + foo]: "heh",
+  ["y" + bar]: "noo"
+};
diff --git a/...-plugin-transform-computed-properties/test/fixtures/loose/setComputedProperties/output.js b/...-plugin-transform-computed-properties/test/fixtures/loose/setComputedProperties/output.js
@@ -0,0 +1,3 @@
+var _obj;
+
+var obj = (_obj = {}, _obj["x" + foo] = "heh", _obj["y" + bar] = "noo", _obj);