Babel should not silently remove unknown options after command… (#10698)

* chore: add test case * chore: bump commander to 4.0.1 * fix: let commander.js throw on unknown options after args
babel · Nov 12, 2019 · 7633f09 · 7633f09
1 parent ce070ce
commit 7633f09
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 1 deletion.
diff --git a/packages/babel-cli/package.json b/packages/babel-cli/package.json
@@ -19,7 +19,7 @@
     "compiler"
   ],
   "dependencies": {
-    "commander": "^2.8.1",
+    "commander": "^4.0.1",
     "convert-source-map": "^1.1.0",
     "fs-readdir-recursive": "^1.1.0",
     "glob": "^7.0.0",

diff --git a/packages/babel-cli/src/babel/options.js b/packages/babel-cli/src/babel/options.js
@@ -163,6 +163,10 @@ commander.option(
 
 commander.version(pkg.version + " (@babel/core " + version + ")");
 commander.usage("[options] <files ...>");
+// register an empty action handler so that commander.js can throw on
+// unknown options _after_ args
+// see https://github.com/tj/commander.js/issues/561#issuecomment-522209408
+commander.action(() => {});
 
 export type CmdOptions = {
   babelOptions: Object,

diff --git a/packages/babel-cli/test/fixtures/babel/error incorrect options after args/in-files/script.js b/packages/babel-cli/test/fixtures/babel/error incorrect options after args/in-files/script.js
@@ -0,0 +1 @@
+arr.map(x => x * MULTIPLIER);
diff --git a/packages/babel-cli/test/fixtures/babel/error incorrect options after args/options.json b/packages/babel-cli/test/fixtures/babel/error incorrect options after args/options.json
@@ -0,0 +1,4 @@
+{
+  "args": ["script.js", "--spruce-maps"],
+  "stderrContains": true
+}
diff --git a/packages/babel-cli/test/fixtures/babel/error incorrect options after args/stderr.txt b/packages/babel-cli/test/fixtures/babel/error incorrect options after args/stderr.txt
@@ -0,0 +1 @@
+error: unknown option '--spruce-maps'
diff --git a/...ages/babel-cli/test/fixtures/babel/error incorrect options before args/in-files/script.js b/...ages/babel-cli/test/fixtures/babel/error incorrect options before args/in-files/script.js
@@ -0,0 +1 @@
+arr.map(x => x * MULTIPLIER);
diff --git a/packages/babel-cli/test/fixtures/babel/error incorrect options before args/options.json b/packages/babel-cli/test/fixtures/babel/error incorrect options before args/options.json
@@ -0,0 +1,4 @@
+{
+  "args": ["--spruce-maps", "script.js"],
+  "stderrContains": true
+}
diff --git a/packages/babel-cli/test/fixtures/babel/error incorrect options before args/stderr.txt b/packages/babel-cli/test/fixtures/babel/error incorrect options before args/stderr.txt
@@ -0,0 +1 @@
+error: unknown option '--spruce-maps'