Skip to content

Commit

Permalink
Revert "Do not automatically publish eslint packages (#10722)"
Browse files Browse the repository at this point in the history
This reverts commit 5ca8acd.

# Conflicts:
#	Makefile
#	eslint/babel-eslint-parser/package.json
#	eslint/babel-eslint-plugin-development/package.json
#	lerna.json
#	scripts/integration-tests/publish-local.sh
  • Loading branch information
JLHwung committed Jul 29, 2020
1 parent c280729 commit 775003f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 28 deletions.
12 changes: 0 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,6 @@ endif
$(YARN) lerna publish from-git --registry http://localhost:4873 --yes --tag-version-prefix="version-e2e-test-"
$(MAKE) clean

publish-eslint:
$(call set-json-field, ./eslint/$(PKG)/package.json, private, false)
cd eslint/$(PKG); yarn publish
$(call set-json-field, ./eslint/$(PKG)/package.json, private, true)

bootstrap-only: lerna-bootstrap

yarn-install: clean-all
Expand Down Expand Up @@ -312,10 +307,3 @@ define clean-source-all
rm -rf $(1)/*/package-lock.json

endef

define set-json-field
$(NODE) -e "\
require('fs').writeFileSync('$1'.trim(), \
JSON.stringify({ ...require('$1'.trim()), $2: $3 }, null, 2) + '\\n' \
)"
endef
1 change: 0 additions & 1 deletion eslint/babel-eslint-config-internal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"author": "The Babel Team (https://babeljs.io/team)",
"homepage": "https://babeljs.io/",
"license": "MIT",
"private": true,
"repository": {
"type": "git",
"url": "https://github.com/babel/babel.git",
Expand Down
4 changes: 1 addition & 3 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
"**/test/**",
"codemods/**",
"# We ignore every JSON file, except for native-modules, built-ins and plugins defined in babel-preset-env/data.",
"@(!(native-modules|built-ins|plugins|package)).json",
"# Until the ESLint packages version are aligned with Babel's, we ignore them",
"eslint/**"
"@(!(native-modules|built-ins|plugins|package)).json"
]
}
},
Expand Down
12 changes: 0 additions & 12 deletions scripts/integration-tests/publish-local.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,6 @@ source utils/local-registry.sh
source utils/git.sh
source utils/cleanup.sh

function publishESLintPkg {
cd eslint/$1
yarn version --new-version $2 --no-git-tag-version
cd ../..
make -j publish-eslint PKG=$1
}

# Echo every command being executed
set -x

Expand All @@ -43,9 +36,4 @@ VERSION=$(

I_AM_USING_VERDACCIO=I_AM_SURE VERSION="$VERSION" make publish-test

publishESLintPkg babel-eslint-config-internal "$VERSION"
publishESLintPkg babel-eslint-parser "$VERSION"
publishESLintPkg babel-eslint-plugin "$VERSION"
publishESLintPkg babel-eslint-plugin-development "$VERSION"

cleanup

0 comments on commit 775003f

Please sign in to comment.