Fix bug

babel · May 29, 2023 · 7afa628 · 7afa628
1 parent 961233c
commit 7afa628
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/packages/babel-preset-env/test/fixtures/preset-options/destructuring-edge/output.js b/packages/babel-preset-env/test/fixtures/preset-options/destructuring-edge/output.js
@@ -1,8 +1,8 @@
 ((a, {
   b: _b = 0,
-  c = 3
+  c: _c = 3
 }) => {
-  return a === 1 && _b === 2 && c === 3;
+  return a === 1 && _b === 2 && _c === 3;
 })(1, {
   b: 2
 });
diff --git a/packages/babel-traverse/src/scope/lib/renamer.ts b/packages/babel-traverse/src/scope/lib/renamer.ts
@@ -27,20 +27,15 @@ const renameVisitor: Visitor<Renamer> = {
       }
     }
   },
-  ObjectProperty(path: NodePath<ObjectProperty>) {
-    const { extra, key, value, computed, shorthand } = path.node;
 
-    if (computed) {
-      return;
-    }
-
-    if (!shorthand) {
-      return;
-    }
+  ObjectProperty(path: NodePath<ObjectProperty>, state) {
+    const { extra, value, shorthand } = path.node;
 
-    if ((key as Identifier).name !== (value as Identifier).name) {
+    if (shorthand && (value as Identifier).name === state.oldName) {
       path.node.shorthand = false;
       if (extra?.shorthand) extra.shorthand = false;
+      // if (extra?.shorthand) extra.shorthand = false;
+      // It will be then renamed by the ReferencedIdentifier visitor.
     }
   },