Feedback from nicolo-ribaudo

babel · Dec 3, 2018 · 7d646b0 · 7d646b0
1 parent f3ecd00
commit 7d646b0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 23 deletions.
diff --git a/packages/babel-plugin-transform-arrow-functions/test/fixtures/arrow-functions/this/output.js b/packages/babel-plugin-transform-arrow-functions/test/fixtures/arrow-functions/this/output.js
@@ -15,12 +15,9 @@ class Foo extends function () {} {
     };
 
     if (true) {
-      var _temp;
-
-      console.log((_temp = super(), _this2 = this, _temp), foo());
+      console.log(super(), foo());
     } else {
       super();
-      _this2 = this;
       console.log(foo());
     }
   }

diff --git a/packages/babel-traverse/src/path/conversion.js b/packages/babel-traverse/src/path/conversion.js
@@ -461,7 +461,8 @@ function getThisBinding(thisEnvFn, inConstructor) {
         if (supers.has(child.node)) return;
         supers.add(child.node);
 
-        child.insertAfter(
+        child.replaceWithMultiple(
+          child.node,
           t.assignmentExpression(
             "=",
             t.identifier(thisBinding),

diff --git a/packages/babel-traverse/test/arrow-transform.js b/packages/babel-traverse/test/arrow-transform.js
@@ -82,12 +82,8 @@ describe("arrow function conversion", () => {
       () => this;
     `,
       `
-      var _supercall = (..._args) => {
-        var _temp;
-
-        return _temp = super(..._args), _this = this, _temp;
-      },
-          _this;
+      var _supercall = (..._args) => super(..._args),
+        _this;
 
       (function () {
         _supercall(345);
@@ -120,13 +116,8 @@ describe("arrow function conversion", () => {
         _this;
       });
       super();
-      _this = this;
       this;
-      () => {
-        var _temp;
-
-        return _temp = super(), _this = this, _temp;
-      }
+      () => super();
       () => this;
     `,
       { methodName: "constructor", extend: true },
@@ -154,13 +145,8 @@ describe("arrow function conversion", () => {
         _this;
       }).bind(_arrowCheckId);
       super();
-      _this = this;
       this;
-      () => {
-        var _temp;
-
-        return _temp = super(), _this = this, _temp;
-      }
+      () => super();
       () => this;
     `,
       {