fix: TS plugin shouldn't remove #privateField! (#14890)

babel · Aug 30, 2022 · 7ddad47 · 7ddad47
1 parent 2626f18
commit 7ddad47
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 2 deletions.
diff --git a/packages/babel-plugin-transform-typescript/src/index.ts b/packages/babel-plugin-transform-typescript/src/index.ts
@@ -124,7 +124,11 @@ export default declare((api, opts: Options) => {
         if (!process.env.BABEL_8_BREAKING) {
           // keep the definitely assigned fields only when `allowDeclareFields` (equivalent of
           // Typescript's `useDefineForClassFields`) is true
-          if (!allowDeclareFields && !node.decorators) {
+          if (
+            !allowDeclareFields &&
+            !node.decorators &&
+            !t.isClassPrivateProperty(node)
+          ) {
             path.remove();
           }
         }

diff --git a/...l-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/input.ts b/...l-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/input.ts
@@ -1,3 +1,5 @@
 class A {
   x!;
+
+  #y!;
 }
diff --git a/...-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/output.js b/...-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/output.js
@@ -1,3 +1,4 @@
 class A {
   x;
+  #y;
 }
diff --git a/...escript/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/input.ts b/...escript/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/input.ts
@@ -1,3 +1,5 @@
 class A {
   x!;
+
+  #y!;
 }
diff --git a/...script/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/output.js b/...script/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/output.js
@@ -1 +1,3 @@
-class A {}
+class A {
+  #y;
+}