Skip to content

Commit

Permalink
review
Browse files Browse the repository at this point in the history
  • Loading branch information
@liuxingbaoyu
liuxingbaoyu committed Jul 30, 2023
1 parent 7972c5c commit 7e1f8d2
Show file tree
Hide file tree
Showing 7 changed files with 62 additions and 53 deletions.
12 changes: 6 additions & 6 deletions packages/babel-traverse/scripts/generators/asserts.js
View file
Expand Up @@ -8,12 +8,12 @@ export default function generateAsserts() {
import type * as t from "@babel/types";
import type NodePath from "../index";
type Opts<Object> = Partial<{
[Prop in keyof Object]: Object[Prop] extends t.Node
? t.Node | Object[Prop]
: Object[Prop] extends t.Node[]
? t.Node[] | Object[Prop]
: Object[Prop];
type Opts<Obj> = Partial<{
[Prop in keyof Obj]: Obj[Prop] extends t.Node
? t.Node
: Obj[Prop] extends t.Node[]
? t.Node[]
: Obj[Prop];
}>;
export interface NodePathAssertions {`;
Expand Down
12 changes: 6 additions & 6 deletions packages/babel-traverse/scripts/generators/validators.js
View file
Expand Up @@ -9,12 +9,12 @@ import type * as t from "@babel/types";
import type NodePath from "../index";
import type { VirtualTypeNodePathValidators } from "../lib/virtual-types-validator";
type Opts<Object> = Partial<{
[Prop in keyof Object]: Object[Prop] extends t.Node
? t.Node | Object[Prop]
: Object[Prop] extends t.Node[]
? t.Node[] | Object[Prop]
: Object[Prop];
type Opts<Obj> = Partial<{
[Prop in keyof Obj]: Obj[Prop] extends t.Node
? t.Node
: Obj[Prop] extends t.Node[]
? t.Node[]
: Obj[Prop];
}>;
interface BaseNodePathValidators {
Expand Down
12 changes: 6 additions & 6 deletions packages/babel-traverse/src/path/generated/asserts.d.ts
View file
Expand Up @@ -5,12 +5,12 @@
import type * as t from "@babel/types";
import type NodePath from "../index";

type Opts<Object> = Partial<{
[Prop in keyof Object]: Object[Prop] extends t.Node
? t.Node | Object[Prop]
: Object[Prop] extends t.Node[]
? t.Node[] | Object[Prop]
: Object[Prop];
type Opts<Obj> = Partial<{
[Prop in keyof Obj]: Obj[Prop] extends t.Node
? t.Node
: Obj[Prop] extends t.Node[]
? t.Node[]
: Obj[Prop];
}>;

export interface NodePathAssertions {
Expand Down
12 changes: 6 additions & 6 deletions packages/babel-traverse/src/path/generated/validators.d.ts
View file
Expand Up @@ -6,12 +6,12 @@ import type * as t from "@babel/types";
import type NodePath from "../index";
import type { VirtualTypeNodePathValidators } from "../lib/virtual-types-validator";

type Opts<Object> = Partial<{
[Prop in keyof Object]: Object[Prop] extends t.Node
? t.Node | Object[Prop]
: Object[Prop] extends t.Node[]
? t.Node[] | Object[Prop]
: Object[Prop];
type Opts<Obj> = Partial<{
[Prop in keyof Obj]: Obj[Prop] extends t.Node
? t.Node
: Obj[Prop] extends t.Node[]
? t.Node[]
: Obj[Prop];
}>;

interface BaseNodePathValidators {
Expand Down
43 changes: 26 additions & 17 deletions packages/babel-traverse/src/path/lib/virtual-types-validator.ts
View file
Expand Up @@ -26,13 +26,14 @@ import type * as t from "@babel/types";
const { isCompatTag } = react;
import type { VirtualTypeAliases } from "./virtual-types";

type Opts<Object> = Partial<{
[Prop in keyof Object]: Object[Prop] extends t.Node
? t.Node | Object[Prop]
: Object[Prop] extends t.Node[]
? t.Node[] | Object[Prop]
: Object[Prop];
type Opts<Obj> = Partial<{
[Prop in keyof Obj]: Obj[Prop] extends t.Node
? t.Node
: Obj[Prop] extends t.Node[]
? t.Node[]
: Obj[Prop];
}>;

export interface VirtualTypeNodePathValidators {
isBindingIdentifier<T extends t.Node>(
this: NodePath<T>,
Expand Down Expand Up @@ -210,15 +211,23 @@ export function isForAwaitStatement(this: NodePath): boolean {
return isForOfStatement(this.node, { await: true });
}

// TODO: Remove in Babel 8
export function isExistentialTypeParam(this: NodePath): void {
throw new Error(
"`path.isExistentialTypeParam` has been renamed to `path.isExistsTypeAnnotation()` in Babel 7.",
);
}

export function isNumericLiteralTypeAnnotation(this: NodePath): void {
throw new Error(
"`path.isNumericLiteralTypeAnnotation()` has been renamed to `path.isNumberLiteralTypeAnnotation()` in Babel 7.",
);
if (!process.env.BABEL_8_BREAKING) {
if (!USE_ESM) {
// eslint-disable-next-line no-restricted-globals
exports.isExistentialTypeParam = function isExistentialTypeParam(
this: NodePath,
): void {
throw new Error(
"`path.isExistentialTypeParam` has been renamed to `path.isExistsTypeAnnotation()` in Babel 7.",
);
};

// eslint-disable-next-line no-restricted-globals
exports.isNumericLiteralTypeAnnotation =
function isNumericLiteralTypeAnnotation(this: NodePath): void {
throw new Error(
"`path.isNumericLiteralTypeAnnotation()` has been renamed to `path.isNumberLiteralTypeAnnotation()` in Babel 7.",
);
};
}
}
12 changes: 6 additions & 6 deletions packages/babel-types/scripts/generators/validators.js
View file
Expand Up @@ -81,12 +81,12 @@ import shallowEqual from "../../utils/shallowEqual";
import type * as t from "../..";
import deprecationWarning from "../../utils/deprecationWarning";
type Opts<Object> = Partial<{
[Prop in keyof Object]: Object[Prop] extends t.Node
? t.Node | Object[Prop]
: Object[Prop] extends t.Node[]
? t.Node[] | Object[Prop]
: Object[Prop];
type Opts<Obj> = Partial<{
[Prop in keyof Obj]: Obj[Prop] extends t.Node
? t.Node
: Obj[Prop] extends t.Node[]
? t.Node[]
: Obj[Prop];
}>;
`;
Expand Down
12 changes: 6 additions & 6 deletions packages/babel-types/src/validators/generated/index.ts
View file
Expand Up @@ -9,12 +9,12 @@ import shallowEqual from "../../utils/shallowEqual";
import type * as t from "../..";
import deprecationWarning from "../../utils/deprecationWarning";

type Opts<Object> = Partial<{
[Prop in keyof Object]: Object[Prop] extends t.Node
? t.Node | Object[Prop]
: Object[Prop] extends t.Node[]
? t.Node[] | Object[Prop]
: Object[Prop];
type Opts<Obj> = Partial<{
[Prop in keyof Obj]: Obj[Prop] extends t.Node
? t.Node
: Obj[Prop] extends t.Node[]
? t.Node[]
: Obj[Prop];
}>;

export function isArrayExpression(
Expand Down

0 comments on commit 7e1f8d2

Please sign in to comment.