handle objectMethod in scope.isPure (#11482)

babel · Apr 25, 2020 · 83d365a · 83d365a
1 parent 0bbf2da
commit 83d365a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/babel-traverse/src/scope/index.js b/packages/babel-traverse/src/scope/index.js
@@ -723,7 +723,7 @@ export default class Scope {
         if (!this.isPure(prop, constantsOnly)) return false;
       }
       return true;
-    } else if (t.isClassMethod(node)) {
+    } else if (t.isMethod(node)) {
       if (node.computed && !this.isPure(node.key, constantsOnly)) return false;
       if (node.kind === "get" || node.kind === "set") return false;
       return true;

diff --git a/packages/babel-traverse/test/scope.js b/packages/babel-traverse/test/scope.js
@@ -203,11 +203,17 @@ describe("scope", () => {
 
     it("purity", function() {
       expect(
-        getPath("({ x: 1 })")
+        getPath("({ x: 1, foo() { return 1 } })")
           .get("body")[0]
           .get("expression")
           .isPure(),
       ).toBeTruthy();
+      expect(
+        getPath("class X { get foo() { return 1 } }")
+          .get("body")[0]
+          .get("expression")
+          .isPure(),
+      ).toBeFalsy();
       expect(
         getPath("`${a}`")
           .get("body")[0]