fix flow-strip-types/flow-comments removing entire ClassProperty (#4587)

babel · Sep 28, 2016 · 8709899 · 8709899
1 parent 5ea57d5
commit 8709899
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 1 deletion.
diff --git a/...el-plugin-transform-flow-comments/test/fixtures/flow-comments/class-prop-values/actual.js b/...el-plugin-transform-flow-comments/test/fixtures/flow-comments/class-prop-values/actual.js
@@ -0,0 +1,5 @@
+class X {
+  foo = 2
+  bar: number = 3
+  baz: ?string
+}
diff --git a/...-plugin-transform-flow-comments/test/fixtures/flow-comments/class-prop-values/expected.js b/...-plugin-transform-flow-comments/test/fixtures/flow-comments/class-prop-values/expected.js
@@ -0,0 +1,5 @@
+class X {
+  foo = 2;
+  bar /*: number*/ = 3;
+  baz /*: ?string*/;
+}
diff --git a/...plugin-transform-flow-comments/test/fixtures/flow-comments/class-prop-values/options.json b/...plugin-transform-flow-comments/test/fixtures/flow-comments/class-prop-values/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "transform-flow-comments",
+    "syntax-class-properties"
+  ]
+}
diff --git a/...el-plugin-transform-flow-strip-types/test/fixtures/regression/class-prop-values/actual.js b/...el-plugin-transform-flow-strip-types/test/fixtures/regression/class-prop-values/actual.js
@@ -0,0 +1,5 @@
+class X {
+  foo = 2
+  bar: number = 3
+  baz: ?string
+}
diff --git a/...-plugin-transform-flow-strip-types/test/fixtures/regression/class-prop-values/expected.js b/...-plugin-transform-flow-strip-types/test/fixtures/regression/class-prop-values/expected.js
@@ -0,0 +1,4 @@
+class X {
+  foo = 2;
+  bar = 3;
+}
diff --git a/...plugin-transform-flow-strip-types/test/fixtures/regression/class-prop-values/options.json b/...plugin-transform-flow-strip-types/test/fixtures/regression/class-prop-values/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "transform-flow-strip-types",
+    "syntax-class-properties"
+  ]
+}
diff --git a/packages/babel-types/src/definitions/flow.js b/packages/babel-types/src/definitions/flow.js
@@ -45,7 +45,7 @@ defineType("ClassImplements", {
 defineType("ClassProperty", {
   visitor: ["key", "value", "typeAnnotation", "decorators"],
   builder: ["key", "value", "typeAnnotation", "decorators", "computed"],
-  aliases: ["Flow", "Property"],
+  aliases: ["Property"],
   fields: {
     computed: {
       validate: assertValueType("boolean"),