Make unknown assumptions default to undefined

babel · Dec 10, 2020 · 8affe9b · 8affe9b
1 parent 2ec0fa6
commit 8affe9b
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 17 deletions.
diff --git a/packages/babel-core/src/config/helpers/config-api.js b/packages/babel-core/src/config/helpers/config-api.js
@@ -26,7 +26,7 @@ type CallerFactory = ((CallerMetadata | void) => mixed) => SimpleType;
 
 type TargetsFunction = () => Targets;
 
-type AssumptionFunction = (name: string) => boolean;
+type AssumptionFunction = (name: string) => boolean | void;
 
 export type ConfigAPI = {|
   version: string,
@@ -94,7 +94,7 @@ export function makePresetAPI<SideChannel: Context.SimplePreset>(
 export function makePluginAPI<SideChannel: Context.SimplePlugin>(
   cache: CacheConfigurator<SideChannel>,
 ): PluginAPI {
-  const assumption = name => cache.using(data => !!data.assumptions[name]);
+  const assumption = name => cache.using(data => data.assumptions[name]);
 
   return { ...makePresetAPI(cache), assumption };
 }

diff --git a/packages/babel-core/src/config/partial.js b/packages/babel-core/src/config/partial.js
@@ -118,10 +118,7 @@ export default function* loadPrivatePartialConfig(
   if (!configChain) return null;
 
   const merged: ValidatedOptions = {
-    // TODO(Babel 8): everything should default to false. Remove this object.
-    assumptions: {
-      newableArrowFunctions: true,
-    },
+    assumptions: {},
   };
   configChain.options.forEach(opts => {
     mergeOptions((merged: any), opts);

diff --git a/packages/babel-core/src/config/validation/options.js b/packages/babel-core/src/config/validation/options.js
@@ -333,7 +333,6 @@ export type NestingPath = RootPath | OverridesPath | EnvPath;
 
 export const assumptionsNames = new Set<string>([
   "mutableTemplateObject",
-  "newableArrowFunctions",
   "setPublicClassFields",
 ]);
 

diff --git a/packages/babel-core/test/assumptions.js b/packages/babel-core/test/assumptions.js
@@ -39,8 +39,6 @@ describe("assumptions", () => {
     ).toEqual({
       setPublicClassFields: true,
       mutableTemplateObject: true,
-      // This is enabled by default
-      newableArrowFunctions: true,
     });
   });
 
@@ -58,9 +56,9 @@ describe("assumptions", () => {
         api => {
           setPublicClassFields = api.assumption("setPublicClassFields");
 
-          // Unknown assumptions default to "false" and don't throw, so
-          // that plugins can keep compat with older @babel/core versions
-          // when they introduce support for a new assumption.
+          // Unknown assumptions don't throw, so that plugins can keep compat
+          // with older @babel/core versions when they introduce support for
+          // a new assumption.
           unknownAssumption = api.assumption("unknownAssumption");
 
           return {};
@@ -69,7 +67,7 @@ describe("assumptions", () => {
     });
 
     expect(setPublicClassFields).toBe(true);
-    expect(unknownAssumption).toBe(false);
+    expect(unknownAssumption).toBe(undefined);
   });
 
   it("cannot be queried from presets", () => {

diff --git a/packages/babel-core/test/config-chain.js b/packages/babel-core/test/config-chain.js
@@ -985,7 +985,7 @@ describe("buildConfigChain", function () {
       presets: [],
       cloneInputAst: true,
       targets: {},
-      assumptions: { newableArrowFunctions: true },
+      assumptions: {},
     });
     const realEnv = process.env.NODE_ENV;
     const realBabelEnv = process.env.BABEL_ENV;

diff --git a/packages/babel-helper-plugin-utils/src/index.js b/packages/babel-helper-plugin-utils/src/index.js
@@ -28,9 +28,7 @@ const apiPolyfills = {
   },
   // This is supported starting from Babel 7.13
   // TODO(Babel 8): Remove this polyfill
-  assumption: () => () => {
-    return false;
-  },
+  assumption: () => () => {},
 };
 
 function copyApiObject(api) {