Skip to content

Commit

Permalink
Simplify the helpers for classPrivateField{Get,Set} (#10117)
Browse files Browse the repository at this point in the history
No need to do the hash lookup twice. If the descriptor is not in the
WeakMap `get` returns `undefined`.
  • Loading branch information
arv authored and nicolo-ribaudo committed Jun 21, 2019
1 parent 11fa246 commit 8f8a457
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/babel-helpers/src/helpers.js
Expand Up @@ -1070,10 +1070,10 @@ helpers.classPrivateFieldLooseBase = helper("7.0.0-beta.0")`

helpers.classPrivateFieldGet = helper("7.0.0-beta.0")`
export default function _classPrivateFieldGet(receiver, privateMap) {
if (!privateMap.has(receiver)) {
var descriptor = privateMap.get(receiver);
if (!descriptor) {
throw new TypeError("attempted to get private field on non-instance");
}
var descriptor = privateMap.get(receiver);
if (descriptor.get) {
return descriptor.get.call(receiver);
}
Expand All @@ -1083,10 +1083,10 @@ helpers.classPrivateFieldGet = helper("7.0.0-beta.0")`

helpers.classPrivateFieldSet = helper("7.0.0-beta.0")`
export default function _classPrivateFieldSet(receiver, privateMap, value) {
if (!privateMap.has(receiver)) {
var descriptor = privateMap.get(receiver);
if (!descriptor) {
throw new TypeError("attempted to set private field on non-instance");
}
var descriptor = privateMap.get(receiver);
if (descriptor.set) {
descriptor.set.call(receiver, value);
} else {
Expand Down

0 comments on commit 8f8a457

Please sign in to comment.