maintain estree string literal shape when cloned

babel · Dec 9, 2021 · 937365c · 937365c
1 parent 94af0e5
commit 937365c
Show file tree

Hide file tree

Showing 5 changed files with 54 additions and 3 deletions.
diff --git a/packages/babel-parser/src/plugins/estree.js b/packages/babel-parser/src/plugins/estree.js
@@ -108,6 +108,14 @@ export default (superClass: Class<Parser>): Class<Parser> =>
       node.expression = false;
     }
 
+    cloneStringLiteral(node: any): any {
+      const cloned = super.cloneStringLiteral(node);
+      cloned.type = "Literal";
+      cloned.raw = cloned.extra.raw;
+      delete cloned.extra;
+      return cloned;
+    }
+
     checkDeclaration(node: N.Pattern | N.ObjectProperty): void {
       if (node != null && this.isObjectProperty(node)) {
         this.checkDeclaration(((node: any): N.EstreeProperty).value);

diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/mixed/options.json b/packages/babel-parser/test/fixtures/estree/module-string-names/mixed/options.json
diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/options.json b/packages/babel-parser/test/fixtures/estree/module-string-names/options.json
@@ -0,0 +1,4 @@
+{
+  "sourceType": "module",
+  "plugins": ["flow", "jsx", "estree"]
+}
diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/input.js b/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/input.js
@@ -0,0 +1 @@
+export { "foo" } from "module-a";
diff --git a/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/output.json b/packages/babel-parser/test/fixtures/estree/module-string-names/shorthand/output.json
@@ -0,0 +1,41 @@
+{
+  "type": "File",
+  "start":0,"end":33,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":33}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":33,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":33}},
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExportNamedDeclaration",
+        "start":0,"end":33,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":33}},
+        "specifiers": [
+          {
+            "type": "ExportSpecifier",
+            "start":9,"end":14,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":14}},
+            "local": {
+              "type": "Literal",
+              "start":9,"end":14,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":14}},
+              "value": "foo",
+              "raw": "\"foo\""
+            },
+            "exported": {
+              "type": "StringLiteral",
+              "start":9,"end":14,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":14}},
+              "value": "foo"
+            }
+          }
+        ],
+        "source": {
+          "type": "Literal",
+          "start":22,"end":32,"loc":{"start":{"line":1,"column":22},"end":{"line":1,"column":32}},
+          "value": "module-a",
+          "raw": "\"module-a\""
+        },
+        "declaration": null,
+        "exportKind": "value"
+      }
+    ]
+  }
+}