Set generator to true during error recovery of accessor (#11987)

babel · Aug 21, 2020 · 941f610 · 941f610
1 parent b9407d7
commit 941f610
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -1767,6 +1767,7 @@ export default class ExpressionParser extends LValParser {
         isAccessor = true;
         prop.kind = keyName;
         if (this.match(tt.star)) {
+          isGenerator = true;
           this.raise(this.state.pos, Errors.AccessorIsGenerator, keyName);
           this.next();
         }
@@ -1827,7 +1828,9 @@ export default class ExpressionParser extends LValParser {
       // isAccessor implies isAsync: false, isPattern: false, isGenerator: false
       this.parseMethod(
         prop,
-        /* isGenerator */ false,
+        // This _should_ be false, but with error recovery, we allow it to be
+        // set for informational purposes
+        isGenerator,
         /* isAsync */ false,
         /* isConstructor */ false,
         false,

diff --git a/packages/babel-parser/test/fixtures/es2015/object/invalid-accessor-generator/output.json b/packages/babel-parser/test/fixtures/es2015/object/invalid-accessor-generator/output.json
@@ -30,7 +30,7 @@
               "computed": false,
               "kind": "get",
               "id": null,
-              "generator": false,
+              "generator": true,
               "async": false,
               "params": [],
               "body": {
@@ -52,7 +52,7 @@
               "computed": false,
               "kind": "set",
               "id": null,
-              "generator": false,
+              "generator": true,
               "async": false,
               "params": [
                 {