fix auto import error with whitespace JSXText (#11354)

babel · Apr 1, 2020 · 9444713 · 9444713
1 parent df819a0
commit 9444713
Show file tree

Hide file tree

Showing 7 changed files with 44 additions and 5 deletions.
diff --git a/packages/babel-helper-builder-react-jsx-experimental/src/index.js b/packages/babel-helper-builder-react-jsx-experimental/src/index.js
@@ -303,12 +303,8 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`,
       "JSXElement|JSXFragment"(path) {
         if (path.type === "JSXFragment") imports.add("Fragment");
         const openingPath = path.get("openingElement");
-        const validChildren = openingPath.parent.children.filter(
-          child =>
-            !t.isJSXEmptyExpression(child) &&
-            !(t.isJSXText(child) && child.value.trim() === ""),
-        );
 
+        const validChildren = t.react.buildChildren(openingPath.parent);
         let importName;
         if (path.type === "JSXElement" && shouldUseCreateElement(path)) {
           importName = "createElement";

diff --git a/packages/babel-plugin-transform-react-jsx/test/fixtures/nextReact/weird-symbols/input.js b/packages/babel-plugin-transform-react-jsx/test/fixtures/nextReact/weird-symbols/input.js
@@ -0,0 +1,5 @@
+class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
+  render() {
+    return <Text>&nbsp;{this.props.value}&nbsp;</Text>;
+  }
+}
diff --git a/packages/babel-plugin-transform-react-jsx/test/fixtures/nextReact/weird-symbols/output.mjs b/packages/babel-plugin-transform-react-jsx/test/fixtures/nextReact/weird-symbols/output.mjs
@@ -0,0 +1,10 @@
+import { jsxs as _jsxs } from "react/jsx-runtime";
+
+class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
+  render() {
+    return /*#__PURE__*/_jsxs(Text, {
+      children: ["\xA0", this.props.value, "\xA0"]
+    });
+  }
+
+}
diff --git a/...es/babel-plugin-transform-react-jsx/test/fixtures/nextReactClassic/weird-symbols/input.js b/...es/babel-plugin-transform-react-jsx/test/fixtures/nextReactClassic/weird-symbols/input.js
@@ -0,0 +1,7 @@
+/** @jsxRuntime classic */
+
+class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
+  render() {
+    return <Text>&nbsp;{this.props.value}&nbsp;</Text>;
+  }
+}
diff --git a/...s/babel-plugin-transform-react-jsx/test/fixtures/nextReactClassic/weird-symbols/output.js b/...s/babel-plugin-transform-react-jsx/test/fixtures/nextReactClassic/weird-symbols/output.js
@@ -0,0 +1,7 @@
+/** @jsxRuntime classic */
+class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
+  render() {
+    return /*#__PURE__*/React.createElement(Text, null, "\xA0", this.props.value, "\xA0");
+  }
+
+}
diff --git a/packages/babel-plugin-transform-react-jsx/test/fixtures/react/weird-symbols/input.js b/packages/babel-plugin-transform-react-jsx/test/fixtures/react/weird-symbols/input.js
@@ -0,0 +1,7 @@
+/** @jsxRuntime classic */
+
+class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
+  render() {
+    return <Text>&nbsp;{this.props.value}&nbsp;</Text>;
+  }
+}
diff --git a/packages/babel-plugin-transform-react-jsx/test/fixtures/react/weird-symbols/output.js b/packages/babel-plugin-transform-react-jsx/test/fixtures/react/weird-symbols/output.js
@@ -0,0 +1,7 @@
+/** @jsxRuntime classic */
+class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
+  render() {
+    return /*#__PURE__*/React.createElement(Text, null, "\xA0", this.props.value, "\xA0");
+  }
+
+}