review

babel · Jul 16, 2022 · 95bb3bb · 95bb3bb
1 parent 90a28cb
commit 95bb3bb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/packages/babel-types/src/definitions/core.ts b/packages/babel-types/src/definitions/core.ts
@@ -1977,9 +1977,6 @@ defineType("TemplateElement", {
         }),
         function templateElementCookedValidator(node: t.TemplateElement) {
           const raw = node.value.raw;
-          if (node.value.cooked != null) {
-            return;
-          }
 
           let cooked = null;
           try {

diff --git a/packages/babel-types/test/builders/es2015/__snapshots__/templateElement.js.snap b/packages/babel-types/test/builders/es2015/__snapshots__/templateElement.js.snap
@@ -59,6 +59,17 @@ Object {
 }
 `;
 
+exports[`builders es2015 templateElement should validate 8`] = `
+Object {
+  "tail": false,
+  "type": "TemplateElement",
+  "value": Object {
+    "cooked": "B",
+    "raw": "\\\\x42",
+  },
+}
+`;
+
 exports[`builders es2015 templateLiteral should validate 1`] = `
 Object {
   "expressions": Array [],

diff --git a/packages/babel-types/test/builders/es2015/templateElement.js b/packages/babel-types/test/builders/es2015/templateElement.js
@@ -23,6 +23,10 @@ describe("builders", function () {
         expect(t.templateElement({ raw: "\\u" })).toMatchSnapshot();
 
         expect(t.templateElement({ raw: "\\x42" })).toMatchSnapshot();
+
+        expect(
+          t.templateElement({ raw: "\\x42", cooked: "123" }),
+        ).toMatchSnapshot();
       });
     });
     describe("templateLiteral", function () {