Require fields transform for class with private fields (#16135)

babel · Nov 28, 2023 · a31c4b9 · a31c4b9
1 parent c100223
commit a31c4b9
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 1 deletion.
diff --git a/packages/babel-plugin-transform-classes/src/transformClass.ts b/packages/babel-plugin-transform-classes/src/transformClass.ts
@@ -214,7 +214,7 @@ export default function transformClass(
     for (const path of classBodyPaths) {
       const node = path.node;
 
-      if (path.isClassProperty()) {
+      if (path.isClassProperty() || path.isClassPrivateProperty()) {
         throw path.buildCodeFrameError("Missing class properties transform.");
       }
 

diff --git a/...-transform-classes/test/fixtures/misc/missing-class-properties-transform-private/input.js b/...-transform-classes/test/fixtures/misc/missing-class-properties-transform-private/input.js
@@ -0,0 +1,7 @@
+class Test {
+  #key = '';
+
+  method() {
+      return this.#key;
+  }
+}
diff --git a/...nsform-classes/test/fixtures/misc/missing-class-properties-transform-private/options.json b/...nsform-classes/test/fixtures/misc/missing-class-properties-transform-private/options.json
@@ -0,0 +1,4 @@
+{
+  "plugins": ["transform-classes"],
+  "throws": "Missing class properties transform."
+}
diff --git a/...n-transform-classes/test/fixtures/misc/missing-class-properties-transform-public/input.js b/...n-transform-classes/test/fixtures/misc/missing-class-properties-transform-public/input.js
@@ -0,0 +1,7 @@
+class Test {
+  key = '';
+
+  method() {
+      return this.key;
+  }
+}
diff --git a/...ansform-classes/test/fixtures/misc/missing-class-properties-transform-public/options.json b/...ansform-classes/test/fixtures/misc/missing-class-properties-transform-public/options.json
@@ -0,0 +1,4 @@
+{
+  "plugins": ["transform-classes"],
+  "throws": "Missing class properties transform."
+}