print parenthesis around forced calls of optional chains (#11190)

babel · Feb 28, 2020 · a39beda · a39beda
1 parent 9c261ae
commit a39beda
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/packages/babel-generator/src/node/parentheses.js b/packages/babel-generator/src/node/parentheses.js
@@ -255,7 +255,17 @@ export function OptionalMemberExpression(
   node: Object,
   parent: Object,
 ): boolean {
-  return t.isCallExpression(parent) || t.isMemberExpression(parent);
+  return (
+    t.isCallExpression(parent, { callee: node }) ||
+    t.isMemberExpression(parent, { object: node })
+  );
+}
+
+export function OptionalCallExpression(node: Object, parent: Object): boolean {
+  return (
+    t.isCallExpression(parent, { callee: node }) ||
+    t.isMemberExpression(parent, { object: node })
+  );
 }
 
 export function AssignmentExpression(node: Object): boolean {

diff --git a/packages/babel-generator/test/fixtures/types/Optional-CallExpression/input.js b/packages/babel-generator/test/fixtures/types/Optional-CallExpression/input.js
@@ -5,6 +5,14 @@ foo?.(bar());
 foo?.(bar("test"));
 foo(bar?.());
 foo(bar?.("test"));
+(foo?.())();
+(foo?.()).baz;
+foo(bar?.baz);
+foo(bar?.baz());
+foo(bar?.("test"));
+foo[bar?.baz];
+foo[bar?.baz()];
+foo[bar?.("test")];
 a.foo?.();
 a.foo?.("foo");
 a.foo?.("foo", "bar");

diff --git a/packages/babel-generator/test/fixtures/types/Optional-CallExpression/output.js b/packages/babel-generator/test/fixtures/types/Optional-CallExpression/output.js
@@ -5,6 +5,14 @@ foo?.(bar());
 foo?.(bar("test"));
 foo(bar?.());
 foo(bar?.("test"));
+(foo?.())();
+(foo?.()).baz;
+foo(bar?.baz);
+foo(bar?.baz());
+foo(bar?.("test"));
+foo[bar?.baz];
+foo[bar?.baz()];
+foo[bar?.("test")];
 a.foo?.();
 a.foo?.("foo");
 a.foo?.("foo", "bar");