Skip to content

Commit

Permalink
Disallow dependency cycles (#13442)
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolo-ribaudo committed Jun 9, 2021
1 parent d3f4c22 commit a59522d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Expand Up @@ -36,6 +36,9 @@ jobs:
YARN_NODE_LINKER: pnp # use pnp linker for better linking performance: it's meant to update yarn cache only
run: |
yarn install --immutable --skip-builds
- name: Check for dependency cycles
run: |
yarn release-tool check-cycles
test-coverage:
name: Test on Node.js Latest
Expand Down
4 changes: 2 additions & 2 deletions .yarn/plugins/@yarnpkg/plugin-babel-release-tool.cjs

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions packages/babel-helper-hoist-variables/package.json
Expand Up @@ -13,11 +13,13 @@
"access": "public"
},
"main": "./lib/index.js",
"TODO": "The @babel/traverse dependency is only needed for the NodePath TS type. After converting @babel/core to TS we can import NodePath from there.",
"dependencies": {
"@babel/traverse": "workspace:^7.13.15",
"@babel/types": "workspace:^7.13.16"
},
"TODO": "The @babel/traverse dependency is only needed for the NodePath TS type. We can consider exporting it from @babel/core.",
"devDependencies": {
"@babel/traverse": "workspace:*"
},
"engines": {
"node": ">=6.9.0"
},
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Expand Up @@ -596,7 +596,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@babel/helper-hoist-variables@workspace:packages/babel-helper-hoist-variables"
dependencies:
"@babel/traverse": "workspace:^7.13.15"
"@babel/traverse": "workspace:*"
"@babel/types": "workspace:^7.13.16"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -3567,7 +3567,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/traverse@workspace:*, @babel/traverse@workspace:^7.13.0, @babel/traverse@workspace:^7.13.15, @babel/traverse@workspace:^7.14.0, @babel/traverse@workspace:^7.14.2, @babel/traverse@workspace:packages/babel-traverse":
"@babel/traverse@workspace:*, @babel/traverse@workspace:^7.13.0, @babel/traverse@workspace:^7.14.0, @babel/traverse@workspace:^7.14.2, @babel/traverse@workspace:packages/babel-traverse":
version: 0.0.0-use.local
resolution: "@babel/traverse@workspace:packages/babel-traverse"
dependencies:
Expand Down

0 comments on commit a59522d

Please sign in to comment.