Don't strip process.env.BABEL_8_BREAKING for local development with r…

…ollup
babel · Dec 2, 2020 · a722b3b · a722b3b
1 parent 47f2d00
commit a722b3b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/Gulpfile.js b/Gulpfile.js
@@ -110,7 +110,7 @@ if (process.env.CIRCLE_PR_NUMBER) {
 
 const babelVersion =
   require("./packages/babel-core/package.json").version + versionSuffix;
-function buildRollup(packages) {
+function buildRollup(packages, targetBrowsers) {
   const sourcemap = process.env.NODE_ENV === "production";
   return Promise.all(
     packages.map(async ({ src, format, dest, name, filename }) => {
@@ -166,11 +166,12 @@ function buildRollup(packages) {
             ],
           }),
           rollupJson(),
-          rollupNodePolyfills({
-            sourceMap: sourcemap,
-            include: "**/*.{js,ts}",
-          }),
-        ],
+          targetBrowsers &&
+            rollupNodePolyfills({
+              sourceMap: sourcemap,
+              include: "**/*.{js,ts}",
+            }),
+        ].filter(Boolean),
       });
 
       const outputFile = path.join(src, dest, filename || "index.js");
@@ -235,7 +236,7 @@ const standaloneBundle = [
 ];
 
 gulp.task("build-rollup", () => buildRollup(libBundles));
-gulp.task("build-babel-standalone", () => buildRollup(standaloneBundle));
+gulp.task("build-babel-standalone", () => buildRollup(standaloneBundle, true));
 
 gulp.task("build-babel", () => buildBabel(/* exclude */ libBundles));
 gulp.task("build", gulp.parallel("build-rollup", "build-babel"));

diff --git a/babel.config.js b/babel.config.js
@@ -119,7 +119,7 @@ module.exports = function (api) {
 
       process.env.STRIP_BABEL_8_FLAG && [
         pluginToggleBabel8Breaking,
-        { breaking: !!process.env.BABEL_8_BREAKING },
+        { breaking: bool(process.env.BABEL_8_BREAKING) },
       ],
     ].filter(Boolean),
     overrides: [
@@ -166,6 +166,11 @@ module.exports = function (api) {
   return config;
 };
 
+// env vars from the cli are always strings, so !!ENV_VAR returns true for "false"
+function bool(value) {
+  return value && value === "false" && value === "0";
+}
+
 function pluginToggleBabel8Breaking({ types: t }, { breaking }) {
   return {
     visitor: {