Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop using old JSX transform (#12253)
- Loading branch information
Showing
15 changed files
with
202 additions
and
256 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 15 additions & 12 deletions
27
...abel-plugin-transform-react-jsx-development/test/fixtures/linux/classic-runtime/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,45 @@ | ||
var _jsxFileName = "<CWD>/packages/babel-plugin-transform-react-jsx-development/test/fixtures/linux/classic-runtime/input.js"; | ||
|
||
function _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); } | ||
|
||
var x = /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement("div", { | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 3, | ||
columnNumber: 5 | ||
}, | ||
__self: this | ||
} | ||
}, /*#__PURE__*/React.createElement("div", { | ||
key: "1", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 4, | ||
columnNumber: 9 | ||
}, | ||
__self: this | ||
} | ||
}), /*#__PURE__*/React.createElement("div", { | ||
key: "2", | ||
meow: "wolf", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 5, | ||
columnNumber: 9 | ||
}, | ||
__self: this | ||
} | ||
}), /*#__PURE__*/React.createElement("div", { | ||
key: "3", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 6, | ||
columnNumber: 9 | ||
}, | ||
__self: this | ||
}), /*#__PURE__*/React.createElement("div", { ...props, | ||
} | ||
}), /*#__PURE__*/React.createElement("div", _extends({}, props, { | ||
key: "4", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 7, | ||
columnNumber: 9 | ||
}, | ||
__self: this | ||
}))); | ||
} | ||
})))); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 15 additions & 12 deletions
27
...n-transform-react-jsx-development/test/fixtures/windows/classic-runtime-windows/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,45 @@ | ||
var _jsxFileName = "<CWD>\\packages\\babel-plugin-transform-react-jsx-development\\test\\fixtures\\windows\\classic-runtime-windows\\input.js"; | ||
|
||
function _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); } | ||
|
||
var x = /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement("div", { | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 3, | ||
columnNumber: 5 | ||
}, | ||
__self: this | ||
} | ||
}, /*#__PURE__*/React.createElement("div", { | ||
key: "1", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 4, | ||
columnNumber: 7 | ||
}, | ||
__self: this | ||
} | ||
}), /*#__PURE__*/React.createElement("div", { | ||
key: "2", | ||
meow: "wolf", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 5, | ||
columnNumber: 7 | ||
}, | ||
__self: this | ||
} | ||
}), /*#__PURE__*/React.createElement("div", { | ||
key: "3", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 6, | ||
columnNumber: 7 | ||
}, | ||
__self: this | ||
}), /*#__PURE__*/React.createElement("div", { ...props, | ||
} | ||
}), /*#__PURE__*/React.createElement("div", _extends({}, props, { | ||
key: "4", | ||
__self: this, | ||
__source: { | ||
fileName: _jsxFileName, | ||
lineNumber: 7, | ||
columnNumber: 7 | ||
}, | ||
__self: this | ||
}))); | ||
} | ||
})))); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,54 @@ | ||
/* eslint-disable-next-line @babel/development/plugin-name */ | ||
import transformClassic from "./transform-classic"; | ||
/* eslint-disable-next-line @babel/development/plugin-name */ | ||
import transformAutomatic from "./transform-automatic"; | ||
import jsx from "@babel/plugin-syntax-jsx"; | ||
import { helper } from "@babel/helper-builder-react-jsx-experimental"; | ||
import { declare } from "@babel/helper-plugin-utils"; | ||
import { types as t } from "@babel/core"; | ||
|
||
export default declare((api, options) => { | ||
const { runtime = "classic" } = options; | ||
const PURE_ANNOTATION = options.pure; | ||
|
||
// we throw a warning in helper-builder-react-jsx-experimental if runtime | ||
// is neither automatic or classic because we will remove this file | ||
// in v8.0.0 | ||
if (runtime === "classic") { | ||
return transformClassic(api, options); | ||
} else { | ||
return transformAutomatic(api, options); | ||
} | ||
const visitor = helper(api, { | ||
pre(state) { | ||
const tagName = state.tagName; | ||
const args = state.args; | ||
if (t.react.isCompatTag(tagName)) { | ||
args.push(t.stringLiteral(tagName)); | ||
} else { | ||
args.push(state.tagExpr); | ||
} | ||
}, | ||
|
||
post(state, pass) { | ||
if (pass.get("@babel/plugin-react-jsx/runtime") === "classic") { | ||
state.createElementCallee = pass.get( | ||
"@babel/plugin-react-jsx/createElementIdentifier", | ||
)(); | ||
|
||
state.pure = | ||
PURE_ANNOTATION ?? !pass.get("@babel/plugin-react-jsx/pragmaSet"); | ||
} else { | ||
state.jsxCallee = pass.get("@babel/plugin-react-jsx/jsxIdentifier")(); | ||
state.jsxStaticCallee = pass.get( | ||
"@babel/plugin-react-jsx/jsxStaticIdentifier", | ||
)(); | ||
state.createElementCallee = pass.get( | ||
"@babel/plugin-react-jsx/createElementIdentifier", | ||
)(); | ||
|
||
state.pure = | ||
PURE_ANNOTATION ?? | ||
!pass.get("@babel/plugin-react-jsx/importSourceSet"); | ||
} | ||
}, | ||
|
||
...options, | ||
development: false, | ||
runtime, | ||
}); | ||
|
||
return { | ||
name: "transform-react-jsx", | ||
inherits: jsx, | ||
visitor, | ||
}; | ||
}); |
Oops, something went wrong.