Skip to content

Commit

Permalink
Move coverage to GitHub actions (#10898)
Browse files Browse the repository at this point in the history
* chore: remove Circle CI test config

* chore: add GitHub Actions: Report Coverage

* chore: polish the step names

* chore: remove Circle CI test job definition

* chore: remove cache actions as it seems that they are hanging forever
  • Loading branch information
JLHwung authored and nicolo-ribaudo committed Dec 20, 2019
1 parent d389b70 commit c5cfc83
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 47 deletions.
47 changes: 0 additions & 47 deletions .circleci/config.yml
Expand Up @@ -9,28 +9,6 @@ aliases:
keys:
- v1-yarn-cache

- &save-node-modules-cache
paths:
- node_modules
key: v1-yarn-deps-{{ checksum "yarn.lock" }}

- &save-yarn-cache
paths:
- ~/.yarn-cache
key: v1-yarn-cache

- &artifact_babel
path: ~/babel/packages/babel-standalone/babel.js

- &artifact_babel_min
path: ~/babel/packages/babel-standalone/babel.min.js

- &artifact_env
path: ~/babel/packages/babel-preset-env-standalone/babel-preset-env.js

- &artifact_env_min
path: ~/babel/packages/babel-preset-env-standalone/babel-preset-env.min.js

- &test262_workdir
working_directory: ~/babel/babel-test262-runner

Expand All @@ -50,28 +28,6 @@ executors:
working_directory: ~/babel

jobs:
test:
executor: node-executor
steps:
- checkout
- restore_cache: *restore-yarn-cache
- restore_cache: *restore-node-modules-cache
- run: yarn --version
- run: make test-ci-coverage
# Builds babel-standalone with the regular Babel config
- run: IS_PUBLISH=true make build
# test-ci-coverage doesn't test babel-standalone, as trying to gather coverage
# data for a JS file that's several megabytes large is bound to fail. Here,
# we just run the babel-standalone test separately.
- run: ./node_modules/.bin/jest packages/babel-standalone/test/
- run: ./node_modules/.bin/jest packages/babel-preset-env-standalone/test/
- store_artifacts: *artifact_babel

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Dec 21, 2019

Member

@JLHwung I just realized that this was used by the REPL 馃槄

This comment has been minimized.

Copy link
@JLHwung

JLHwung Dec 22, 2019

Author Contributor

Good catch, I thought they are only used for the bundlesize. I will see if we can download the artifact without GitHub actions

- store_artifacts: *artifact_babel_min
- store_artifacts: *artifact_env
- store_artifacts: *artifact_env_min
- save_cache: *save-node-modules-cache
- save_cache: *save-yarn-cache

test262:
executor: node-executor
steps:
Expand Down Expand Up @@ -156,9 +112,6 @@ jobs:

workflows:
version: 2
test:
jobs:
- test
test262-master:
jobs:
- test262:
Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/coverage.yml
@@ -0,0 +1,36 @@
name: Report Coverage

on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [13.x]
steps:
- name: Checkout code
uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Environment log
id: env
run: |
yarn --version
- name: Generate coverage report
run: |
yarn --version
make test-ci-coverage
# Builds babel-standalone with the regular Babel config
# test-ci-coverage doesn't test babel-standalone, as trying to gather coverage
IS_PUBLISH=true make build-standalone
# data for a JS file that's several megabytes large is bound to fail. Here,
# we just run the babel-standalone test separately.
yarn jest "\-standalone/test"
- name: Upload coverage report
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}

0 comments on commit c5cfc83

Please sign in to comment.