Skip to content

Commit

Permalink
Update min Babel version for #12917 (#12977)
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolo-ribaudo committed Mar 7, 2021
1 parent 8dacf85 commit c702895
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 20 deletions.
20 changes: 9 additions & 11 deletions Makefile
Expand Up @@ -196,17 +196,15 @@ prepublish:
IS_PUBLISH=true $(MAKE) test

new-version-checklist:
@echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
@echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
@echo "!!!!!! !!!!!!"
@echo "!!!!!! Update classStaticPrivateFieldDestructureSet !!!!!!"
@echo "!!!!!! helper version in !!!!!!"
@echo "!!!!!! packages/babel-helpers/src/helpers.js !!!!!!"
@echo "!!!!!! packages/babel-helper-create-class-features-plugin/src/fields.js"
@echo "!!!!!! !!!!!!"
@echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
@echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
@exit 1
# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
# @echo "!!!!!! !!!!!!"
# @echo "!!!!!! Write any message that should !!!!!!"
# @echo "!!!!!! block the release here !!!!!!"
# @echo "!!!!!! !!!!!!"
# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
# @exit 1

new-version:
$(MAKE) new-version-checklist
Expand Down
Expand Up @@ -323,12 +323,12 @@ const privateNameHandlerSpec = {
const { id, static: isStatic } = privateNamesMap.get(name);
if (isStatic) {
try {
// classStaticPrivateFieldDestructureSet was introduced in 7.99.0
// classStaticPrivateFieldDestructureSet was introduced in 7.13.10
// eslint-disable-next-line no-var
var helper = file.addHelper("classStaticPrivateFieldDestructureSet");
} catch {
throw new Error(
"Babel can not transpile `[C.#p] = [0]` with @babel/helpers < 7.99.0, \n" +
"Babel can not transpile `[C.#p] = [0]` with @babel/helpers < 7.13.10, \n" +
"please update @babel/helpers to the latest version.",
);
}
Expand Down
14 changes: 7 additions & 7 deletions packages/babel-helpers/src/helpers.js
Expand Up @@ -1326,7 +1326,7 @@ helpers.classPrivateFieldDestructureSet = helper("7.4.4")`
}
`;

helpers.classExtractFieldDescriptor = helper("7.99.0")`
helpers.classExtractFieldDescriptor = helper("7.13.10")`
export default function _classExtractFieldDescriptor(receiver, privateMap, action) {
if (!privateMap.has(receiver)) {
throw new TypeError("attempted to " + action + " private field on non-instance");
Expand Down Expand Up @@ -1372,7 +1372,7 @@ helpers.classStaticPrivateMethodSet = helper("7.3.2")`
}
`;

helpers.classApplyDescriptorGet = helper("7.99.0")`
helpers.classApplyDescriptorGet = helper("7.13.10")`
export default function _classApplyDescriptorGet(receiver, descriptor) {
if (descriptor.get) {
return descriptor.get.call(receiver);
Expand All @@ -1381,7 +1381,7 @@ helpers.classApplyDescriptorGet = helper("7.99.0")`
}
`;

helpers.classApplyDescriptorSet = helper("7.99.0")`
helpers.classApplyDescriptorSet = helper("7.13.10")`
export default function _classApplyDescriptorSet(receiver, descriptor, value) {
if (descriptor.set) {
descriptor.set.call(receiver, value);
Expand All @@ -1397,7 +1397,7 @@ helpers.classApplyDescriptorSet = helper("7.99.0")`
}
`;

helpers.classApplyDescriptorDestructureSet = helper("7.99.0")`
helpers.classApplyDescriptorDestructureSet = helper("7.13.10")`
export default function _classApplyDescriptorDestructureSet(receiver, descriptor) {
if (descriptor.set) {
if (!("__destrObj" in descriptor)) {
Expand All @@ -1421,7 +1421,7 @@ helpers.classApplyDescriptorDestructureSet = helper("7.99.0")`
}
`;

helpers.classStaticPrivateFieldDestructureSet = helper("7.99.0")`
helpers.classStaticPrivateFieldDestructureSet = helper("7.13.10")`
import classApplyDescriptorDestructureSet from "classApplyDescriptorDestructureSet";
import classCheckPrivateStaticAccess from "classCheckPrivateStaticAccess";
import classCheckPrivateStaticFieldDescriptor from "classCheckPrivateStaticFieldDescriptor";
Expand All @@ -1432,15 +1432,15 @@ helpers.classStaticPrivateFieldDestructureSet = helper("7.99.0")`
}
`;

helpers.classCheckPrivateStaticAccess = helper("7.99.0")`
helpers.classCheckPrivateStaticAccess = helper("7.13.10")`
export default function _classCheckPrivateStaticAccess(receiver, classConstructor) {
if (receiver !== classConstructor) {
throw new TypeError("Private static access of wrong provenance");
}
}
`;

helpers.classCheckPrivateStaticFieldDescriptor = helper("7.99.0")`
helpers.classCheckPrivateStaticFieldDescriptor = helper("7.13.10")`
export default function _classCheckPrivateStaticFieldDescriptor(descriptor, action) {
if (descriptor === undefined) {
throw new TypeError("attempted to " + action + " private static field before its declaration");
Expand Down

0 comments on commit c702895

Please sign in to comment.