test: add test for babel --filename on windows

babel · Sep 26, 2019 · cba606b · cba606b
1 parent 1ab4a6e
commit cba606b
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 4 deletions.
diff --git a/packages/babel-cli/test/fixtures/babel/stdin --filename windows/options.json b/packages/babel-cli/test/fixtures/babel/stdin --filename windows/options.json
@@ -0,0 +1,5 @@
+{
+  "args": ["--filename", "test.js"],
+  "stderrContains": true,
+  "nodePlatform": ["win32"]
+}
diff --git a/packages/babel-cli/test/fixtures/babel/stdin --filename windows/stderr.txt b/packages/babel-cli/test/fixtures/babel/stdin --filename windows/stderr.txt
@@ -0,0 +1 @@
+SyntaxError: <CWD>\test.js: Unexpected token, expected ";" (2:10)
diff --git a/packages/babel-cli/test/fixtures/babel/stdin --filename windows/stdin.txt b/packages/babel-cli/test/fixtures/babel/stdin --filename windows/stdin.txt
@@ -0,0 +1,3 @@
+arr.map(function () {
+  return $]!;
+});
diff --git a/packages/babel-cli/test/fixtures/babel/stdin --filename/options.json b/packages/babel-cli/test/fixtures/babel/stdin --filename/options.json
@@ -1,4 +1,5 @@
 {
   "args": ["--filename", "test.js"],
-  "stderrContains": true
+  "stderrContains": true,
+  "nodePlatform": ["linux", "darwin"]
 }
diff --git a/packages/babel-cli/test/index.js b/packages/babel-cli/test/index.js
@@ -185,7 +185,32 @@ fs.readdirSync(fixtureLoc).forEach(function(binName) {
       };
 
       const optionsLoc = path.join(testLoc, "options.json");
-      if (fs.existsSync(optionsLoc)) merge(opts, require(optionsLoc));
+      if (fs.existsSync(optionsLoc)) {
+        const taskOpts = require(optionsLoc);
+        if (taskOpts.nodePlatform) {
+          let nodePlatform = taskOpts.nodePlatform;
+
+          if (
+            !Array.isArray(nodePlatform) &&
+            typeof nodePlatform !== "string"
+          ) {
+            throw new Error(
+              `'nodePlatform' should be either string or string array: ${taskOpts.nodePlatform}`,
+            );
+          }
+
+          if (typeof nodePlatform === "string") {
+            nodePlatform = [nodePlatform];
+          }
+
+          if (!nodePlatform.includes(process.platform)) {
+            return;
+          }
+
+          delete taskOpts.nodePlatform;
+        }
+        merge(opts, taskOpts);
+      }
 
       ["stdout", "stdin", "stderr"].forEach(function(key) {
         const loc = path.join(testLoc, key + ".txt");

diff --git a/packages/babel-helper-fixtures/src/index.js b/packages/babel-helper-fixtures/src/index.js
@@ -195,7 +195,7 @@ export default function get(entryLoc): Array<Suite> {
       if (taskOpts.nodePlatform) {
         let nodePlatform = taskOpts.nodePlatform;
 
-        if (!nodePlatform) {
+        if (!Array.isArray(nodePlatform) && typeof nodePlatform !== "string") {
           throw new Error(
             `'nodePlatform' should be either string or string array: ${taskOpts.nodePlatform}`,
           );

diff --git a/packages/babel-preset-react/test/fixtures/preset-options/development-windows/options.json b/packages/babel-preset-react/test/fixtures/preset-options/development-windows/options.json
@@ -1,4 +1,4 @@
 {
   "presets": [["react", { "development": true }]],
-  "nodePlatform": ["windows"]
+  "nodePlatform": ["win32"]
 }